Bug 228518 - emulators/wine-devel: Fix distinfo file for STAGING option (v3.9)
Summary: emulators/wine-devel: Fix distinfo file for STAGING option (v3.9)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Gerald Pfeifer
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-05-26 19:55 UTC by lightside
Modified: 2018-05-26 22:38 UTC (History)
1 user (show)

See Also:


Attachments
Proposed patch (since 470875 revision) (430 bytes, patch)
2018-05-26 19:55 UTC, lightside
lightside: maintainer-approval? (gerald)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description lightside 2018-05-26 19:55:13 UTC
Created attachment 193727 [details]
Proposed patch (since 470875 revision)

Patch to fix distinfo file for emulators/wine-devel port, when STAGING option enabled.

There is following error for emulators/wine-devel port (based on ports r470875 changes):
-8<--
# cd /usr/potrs/emulators/wine-devel
# make WITH=STAGING checksum
===>  License LGPL21 LGPL3 accepted by the user
===>   wine-devel-3.9,1 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by wine-devel-3.9,1 for building
=> SHA256 Checksum OK for wine-3.9.tar.xz.
=> No SHA256 checksum recorded for v3.9.tar.gz.
=> No suitable checksum found for v3.9.tar.gz.
*** Error code 1

Stop.
make: stopped in /usr/ports/emulators/wine-devel
-->8-

Possible fix is usage of `make WITH=STAGING makesum` command:
-8<--
# make WITH=STAGING makesum
<..>
# make WITH=STAGING checksum
===>  License LGPL21 LGPL3 accepted by the user
===>   wine-devel-3.9,1 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by wine-devel-3.9,1 for building
=> SHA256 Checksum OK for wine-3.9.tar.xz.
=> SHA256 Checksum OK for v3.9.tar.gz.
-->8-
Comment 1 lightside 2018-05-26 20:09:36 UTC
Other possible fix is to add following code before ".include <bsd.port.pre.mk>" in emulators/wine-devel/Makefile:
-8<--
.ifmake makesum
# Always include optional distfiles
.MAKEFLAGS:	WITH="${OPTIONS_DEFINE}" OPTIONS_EXCLUDE=
.endif
-->8-

Then `make makesum` command may generate distinfo file for STAGING option also.
For example, this was used for devel/godot port (based on ports r420818 changes).
Comment 2 Gerald Pfeifer freebsd_committer 2018-05-26 21:41:18 UTC
Thank you for the report and the hint on how to adjust the Makefile.

I actually do have a setup where distinfo is updated fully, alas in
this case the Wine Staging patchset simply was not available at that
point in time (and waiting "forever" is too often previous year does
have drawbacks as well).

This update is undergoing testing right now and I hope to commit soon.
Comment 3 commit-hook freebsd_committer 2018-05-26 21:43:45 UTC
A commit references this bug:

Author: gerald
Date: Sat May 26 21:42:58 UTC 2018
New revision: 470950
URL: https://svnweb.freebsd.org/changeset/ports/470950

Log:
  Add information on the Wine Staging patchset (aka the STAGING option)
  for version 3.9.

  PR:		228518
  Submitted by:	lightside@gmx.com

Changes:
  head/emulators/wine-devel/distinfo
Comment 4 lightside 2018-05-26 22:38:10 UTC
(In reply to Gerald Pfeifer from comment #2)
> I actually do have a setup where distinfo is updated fully, alas in
> this case the Wine Staging patchset simply was not available at that
> point in time
Understood.

(In reply to Gerald Pfeifer from comment #2)
> This update is undergoing testing right now and I hope to commit soon.
I tested for locally revived emulators/i386-wine-staging port:
-8<--
% svn co -r 464146 https://svn.FreeBSD.org/ports/head/emulators
% cp -pR emulators/i386-wine-staging .
% rm -rf emulators
% cd i386-wine-staging
% sed -i '' -e '/^BROKEN=/d' Makefile
-->8-

And it worked since 3.4 version. Also I found, that after print/freetype2 update to v2.9 there was a need to use LCD_FILTERING instead of LCD_RENDERING option for my font-config configuration, because of no anti-aliasing for used fonts in winecfg or some other windows, but probably this is configuration related. I tried to explain about this in some emails. Said just in case, because already resolved locally.

Thanks for fast response and commit.