Bug 228587 - [patch] add new ga_IE.UTF-8 locale
Summary: [patch] add new ga_IE.UTF-8 locale
Status: In Progress
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Pankov
URL: https://reviews.freebsd.org/D17997
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-05-29 12:46 UTC by Micil
Modified: 2018-11-26 19:40 UTC (History)
3 users (show)

See Also:


Attachments
LC_TIME file to support the creation of a ga_IE.UTF-8 locale (609 bytes, text/plain)
2018-05-29 12:46 UTC, Micil
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Micil 2018-05-29 12:46:33 UTC
Created attachment 193811 [details]
LC_TIME file to support the creation of a ga_IE.UTF-8 locale

Hello. I'm new to the FreeBSD community. I've read the rules but please be understanding if I accidentally break any :)

I needed a ga_IE.UTF-8 (Irish language_Irish conventions) locale for use in the vt console but, as far as I can tell, FreeBSD doesn't have one so I made my own, based on the en_IE.UTF-8 locale. I don't know if it's correctly-formed but it seems to work in testing so I offer it here as a patch.

I only modified the LC_TIME file. All the others were either symlinks or didn't need changing (with one exception, below) and could be copied across from en_IE.UTF-8. So the modified LC_TIME, with certain strings translated as appropriate, is all I've uploaded here.

There is one thing that probably still needs work. In en_IE.UTF-8, LC_MESSAGES is a link to a file of the same name in en_US.UTF-8. This contains a couple of 'yes' / 'no' strings that are fine for English (Ireland) but not for Irish (Ireland). I thought about copying LC_MESSAGES from en_US.UTF-8 to an actual file in ga_IE.UTF-8 and then adding translations but (1) I couldn't work out the syntax and (2) Irish doesn't have words for 'yes' and 'no'; you use positive and negative forms of whatever verb to articulate equivalent meanings so it can be tricky finding one-size-fits-all strings in cases like this. I'd need to have context.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2018-08-05 04:52:48 UTC
To which file does this patch apply?
Comment 2 Micil 2018-08-07 09:34:01 UTC
> To which file does this patch apply?

The attachment is my localised LC_TIME file, located in a custom ga_IE.UTF‑8 locale directory which I created myself. Specifically, the patch doesn’t apply to an existing FreeBSD file but to a proposed new one.

To create a ga_IE.UTF-8 locale, I copied the existing en_IE.UTF‑8 directory from:

/usr/share/locale/en_IE.UTF‑8

to

/usr/share/locale/ga_IE.UTF‑8

and then localised the appropriate strings in the file:

/usr/share/locale/ga_IE.UTF‑8/LC_TIME

The patch is this localised LC_TIME file. 

The ‘probably still needs work’ aspect applies to the file:

/usr/share/locale/ga_IE.UTF‑8/LC_MESSAGES

which I haven’t modified in any way, for the reasons given.

As far as I can tell, nothing else in the

/usr/share/locale/ga_IE.UTF‑8

directory would need to be changed for it to provide a valid ga_IE.UTF‑8 locale.
Comment 3 commit-hook freebsd_committer 2018-11-26 19:40:22 UTC
A commit references this bug:

Author: yuripv
Date: Mon Nov 26 19:39:52 UTC 2018
New revision: 340992
URL: https://svnweb.freebsd.org/changeset/base/340992

Log:
  Add ga_IE.UTF-8 locale.

  PR:		228587
  Submitted by:	Micil <micheal.maclochlainn@oegaillimh.ie> (LC_TIME)
  Reviewed by:	bapt
  Approved by:	kib (mentor, implicit)
  MFC after:	3 days
  Differential revision:	https://reviews.freebsd.org/D17997

Changes:
  head/etc/mtree/BSD.usr.dist
  head/share/colldef/Makefile
  head/share/ctypedef/Makefile
  head/share/monetdef/Makefile
  head/share/monetdef/en_IE.UTF-8.src
  head/share/monetdef/ga_IE.UTF-8.src
  head/share/msgdef/Makefile
  head/share/msgdef/ga_IE.UTF-8.src
  head/share/numericdef/Makefile
  head/share/timedef/Makefile
  head/share/timedef/ga_IE.UTF-8.src
  head/tools/tools/locale/Makefile
  head/tools/tools/locale/etc/charmaps.xml