Bug 228596 - [NEW PORT] finance/rippled: Reference server implementation of the Ripple protocol
Summary: [NEW PORT] finance/rippled: Reference server implementation of the Ripple pro...
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-29 19:49 UTC by waitman
Modified: 2018-11-29 09:59 UTC (History)
1 user (show)

See Also:


Attachments
shar file for rippled port (4.43 KB, text/plain)
2018-05-29 19:49 UTC, waitman
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description waitman 2018-05-29 19:49:48 UTC
Created attachment 193823 [details]
shar file for rippled port

unfortunately rippled does not shut down properly when build by clang, it's working with gcc6.

should have at least 8GB RAM to build (according to rippled docs)
Comment 1 Tobias Kortkamp freebsd_committer 2018-11-15 06:33:57 UTC
(In reply to waitman from comment #0)
> should have at least 8GB RAM to build (according to rippled docs)
So I guess I'm out in ever landing this.  But here is a short review anyway:

XMASTER_SITES=	https://github.com/ripple/rippled/archive/
XDISTNAME=	${PORTVERSION}
...
XWRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}

Please use USE_GITHUB and related variables here instead of GitHub's
archive feature directly.

XNO_ARCH=	yes

Huh?  If the port builds binaries then this is probably wrong.

X		${INSTALL} ${BUILD_WRKSRC}/rippled ${STAGEDIR}${PREFIX}/sbin/

Use INSTALL_PROGRAM.  Also please fix the indentation here.

X	${INSTALL_DATA} ${WRKSRC}/cfg/rippled-example.cfg ${STAGEDIR}${DOCSDIR}
X	${INSTALL_DATA} ${WRKSRC}/cfg/rippled-example.service ${STAGEDIR}${DOCSDIR}
X	${INSTALL_DATA} ${WRKSRC}/cfg/rippled.init ${STAGEDIR}${DOCSDIR}
X	${INSTALL_DATA} ${WRKSRC}/cfg/validators-example.txt ${STAGEDIR}${DOCSDIR}

The *-example* files should probably be installed into EXAMPLESDIR
(under an EXAMPLES option) instead.

X	@${CAT} ${WRKSRC}/MESSAGE

What's the purpose of this?  Nobody will see this message.  It
will be hidden in the build logs on the package builders.  If this
is a message for after the package has been installed, I suppose
you could add

PKGMESSAGE=	${WRKSRC}/MESSAGE

to the port instead (then there is no point to also install it into
DOCSDIR too).