Bug 228603 - www/qt5-webengine: fix build on arm
Summary: www/qt5-webengine: fix build on arm
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Many People
Assignee: Adriaan de Groot
URL: http://beefy8.nyi.freebsd.org/data/he...
Keywords:
: 228708 (view as bug list)
Depends on:
Blocks: 236855
  Show dependency tree / graph
 
Reported: 2018-05-30 09:48 UTC by Mikael Urankar
Modified: 2019-03-28 16:38 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (kde)

Attachments
patch (11.74 KB, patch)
2018-05-30 09:48 UTC, Mikael Urankar 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2018-05-30 09:48:34 UTC 
Created attachment 193836 [details]
patch

The attached patch fixes the build on armv6 and aarch64.
obtained from: mmel@
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2018-06-04 15:36:18 UTC 
*** Bug 228708 has been marked as a duplicate of this bug. ***
Comment 2 Adriaan de Groot freebsd_committer freebsd_triage 2018-06-04 15:43:37 UTC 
Succesful build reported in PR 228708. I'm just going to test-build this on my Pine64 to double-check.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-06-06 13:53:32 UTC 
A commit references this bug:

Author: adridg
Date: Wed Jun  6 13:53:05 UTC 2018
New revision: 471843
URL: https://svnweb.freebsd.org/changeset/ports/471843

Log:
  Fix www/qt5-webengine to build on ARM

  Fix build for aarch64 and armv7. Chasing Chromium patches into Qt5-Webengine
  is a slow process. Multiple build successes have been reported with
  this patch, although I have not been able to try it myself.

  I hope I got all the attributions right.

  PR:		228603 228708
  Submitted by:	mikael.urankar@gmail.com
  Reported by:	mikael.urankar@gmail.com, usenet@ulrich-grey.de
  Obtained from:	mmel

Changes:
  head/www/qt5-webengine/files/patch-src_3rdparty_chromium_build_config_compiler_BUILD.gn
  head/www/qt5-webengine/files/patch-src_3rdparty_chromium_third__party_boringssl_src_include_openssl_cpu.h
  head/www/qt5-webengine/files/patch-src_3rdparty_chromium_v8_src_arm_cpu-arm.cc
  head/www/qt5-webengine/files/patch-src_3rdparty_chromium_v8_src_base_cpu.cc
  head/www/qt5-webengine/files/patch-src_3rdparty_chromium_v8_src_base_platform_platform-freebsd.cc
  head/www/qt5-webengine/files/patch-src_3rdparty_chromium_v8_src_libsampler_sampler.cc
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2018-06-11 04:11:41 UTC 
Apparently committed as r471843.