Bug 228673 - [PATCH] graphics/mesa-dri - configure script fails with BSD grep
Summary: [PATCH] graphics/mesa-dri - configure script fails with BSD grep
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-x11 mailing list
URL:
Keywords:
Depends on:
Blocks: 228798
  Show dependency treegraph
 
Reported: 2018-06-02 11:22 UTC by Stefan Esser
Modified: 2018-06-22 09:36 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (x11)


Attachments
Patch that replaces GNU grep specific pattern with generic egrep pattern. (754 bytes, patch)
2018-06-02 11:22 UTC, Stefan Esser
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Esser freebsd_committer 2018-06-02 11:22:50 UTC
Created attachment 193910 [details]
Patch that replaces GNU grep specific pattern with generic egrep pattern.

The configure script uses a non-standard syntax not supported by the BSD grep in -CURRENT. This is easily fixed by use of grep -E or egrep (see attached patch, which makes configure work with ancient and current GNU grep and BSD grep).

The problematic command is:

echo $platforms | grep -q "x11\|drm"

The standard compliant form that does not depend on GNU grep is:

echo $platforms | egrep -q "x11|drm"
Comment 1 commit-hook freebsd_committer 2018-06-22 09:36:07 UTC
A commit references this bug:

Author: zeising
Date: Fri Jun 22 09:35:05 UTC 2018
New revision: 473029
URL: https://svnweb.freebsd.org/changeset/ports/473029

Log:
  Add a patch to fix build with BSD grep

  Since this is not the default, no need to bump portrevision.

  PR:		228673
  Submitted by:	Stefan Esser

Changes:
  head/graphics/mesa-dri/files/patch-configure
Comment 2 Niclas Zeising freebsd_committer 2018-06-22 09:36:55 UTC
Fixed, thanks!