Bug 228706 - Templates/config.guess must add gnueabihf to armv6 and armv7 target
Summary: Templates/config.guess must add gnueabihf to armv6 and armv7 target
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Some People
Assignee: Port Management Team
URL:
Keywords: needs-qa
Depends on:
Blocks: 196899
  Show dependency tree / graph
 
Reported: 2018-06-02 18:03 UTC by Mikael Urankar
Modified: 2018-08-13 20:28 UTC (History)
3 users (show)

See Also:
koobs: exp-run?

Attachments
patch (1.12 KB, patch)
2018-06-02 18:03 UTC, Mikael Urankar 		no flags Details | Diff
patch (1.39 KB, patch)
2018-06-17 15:01 UTC, Mikael Urankar 		no flags Details | Diff
corrected patch against latest commits (1.43 KB, patch)
2018-06-29 08:11 UTC, Mark Linimon 		no flags Details | Diff
patch (6.97 KB, patch)
2018-07-18 13:33 UTC, Mikael Urankar 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2018-06-02 18:03:55 UTC 
Created attachment 193946 [details]
patch

Templates/config.guess doesn't add the gnueabihf (or gnueabi for soft float) suffix for armv6 and armv7 which will cause build problem with lang/ghc.

sh /usr/ports/Templates/config.guess
armv7-unknown-freebsd12.0

with my patch:
sh /usr/ports/Templates/config.guess
armv7-unknown-freebsd12.0-gnueabihf
Comment 1 Baptiste Daroussin freebsd_committer freebsd_triage 2018-06-08 09:40:10 UTC 
as it been upstreamed? if not it should.
if yes, then we should update fetch the latest upstream version as we did before.

Sorry I haven't had time to look at upstream yet
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2018-06-08 09:46:22 UTC 
Where is upstream?
Comment 3 Baptiste Daroussin freebsd_committer freebsd_triage 2018-06-08 10:39:19 UTC 
Here: https://savannah.gnu.org/projects/config/
Comment 4 Mikael Urankar freebsd_committer freebsd_triage 2018-06-17 15:01:26 UTC 
Created attachment 194335 [details]
patch

Simplify config.sub

Upstream seems dead. How do you want to proceed? update config.* with latest version from upstream and apply my patch or stay with current version and apply my patch?
Comment 5 Gleb Popov freebsd_committer freebsd_triage 2018-06-17 15:26:07 UTC 
(In reply to mikael.urankar from comment #4)
Judging from http://git.savannah.gnu.org/cgit/config.git/log/ it isn't dead at all.
Comment 6 Mikael Urankar freebsd_committer freebsd_triage 2018-06-17 15:39:26 UTC 
(In reply to Gleb Popov from comment #5)
I sent a mail a week ago and no response so far. I'm probably too impatient.
http://lists.gnu.org/archive/html/config-patches/2018-06/msg00002.html
Comment 7 Gleb Popov freebsd_committer freebsd_triage 2018-06-26 14:59:14 UTC 
(In reply to mikael.urankar from comment #6)
Could you ping upstream aggain, please? This is really taking too long.
Comment 8 Mark Linimon freebsd_committer freebsd_triage 2018-06-29 08:11:31 UTC 
Created attachment 194719 [details]
corrected patch against latest commits

There has been a new commit to config.sub that obsoletes the existing patch.  This should fix it.
Comment 9 Mikael Urankar freebsd_committer freebsd_triage 2018-07-03 12:15:27 UTC 
(In reply to Mark Linimon from comment #8)
No need to patch config.sub with the new version
Comment 10 Gleb Popov freebsd_committer freebsd_triage 2018-07-14 16:24:32 UTC 
Upstream is ignoring this patch. Can we get it into FreeBSD then?
Comment 11 Mikael Urankar freebsd_committer freebsd_triage 2018-07-15 16:28:32 UTC 
upstream is alive \o/
Comment 12 Mikael Urankar freebsd_committer freebsd_triage 2018-07-18 13:33:06 UTC 
Created attachment 195241 [details]
patch

My patch is accepted upstream:
http://git.savannah.gnu.org/cgit/config.git/commit/?id=afe1fa96bf32291d51fe337902ab8a2af176fe8d

I've attached an updated patch.
Comment 13 Mikael Urankar freebsd_committer freebsd_triage 2018-07-18 13:35:26 UTC 
Should I request an exp-run?
Comment 14 Mikael Urankar freebsd_committer freebsd_triage 2018-08-06 14:26:07 UTC 
ping?
Comment 15 commit-hook freebsd_committer freebsd_triage 2018-08-13 20:26:43 UTC 
A commit references this bug:

Author: antoine
Date: Mon Aug 13 20:26:06 UTC 2018
New revision: 477111
URL: https://svnweb.freebsd.org/changeset/ports/477111

Log:
  Merge config.guess upstream changes up to 2018-07-18
  This includes gnueabihf addition to armv6 and armv7 targets

  PR:		228706
  Submitted by:	Mikael Urankar
  With hat:	portmgr

Changes:
  head/Templates/config.guess