Bug 228732 - converters/wkhtmltopdf unbreak build with clang 6.0
Summary: converters/wkhtmltopdf unbreak build with clang 6.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-06-04 01:52 UTC by Don Lewis
Modified: 2018-06-13 05:24 UTC (History)
1 user (show)

See Also:
pi: maintainer-feedback+


Attachments
patch to unbreak wkhtmltopdf build with clang 6.0 (716 bytes, patch)
2018-06-04 01:52 UTC, Don Lewis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Lewis freebsd_committer 2018-06-04 01:52:23 UTC
Created attachment 193980 [details]
patch to unbreak wkhtmltopdf build with clang 6.0

wkhtmltopdf fails to build with clang 6.0 and is marked BROKEN.  The attached patch adds
  USE_CXXSTD=	gnu++98
to the Makefile which switches clang back to the C++ standard that it used before  version 6.0.  I am able to build wkhtmltopdf with this change.
Comment 1 commit-hook freebsd_committer 2018-06-13 05:24:38 UTC
A commit references this bug:

Author: pi
Date: Wed Jun 13 05:24:28 UTC 2018
New revision: 472285
URL: https://svnweb.freebsd.org/changeset/ports/472285

Log:
  converters/wkhtmltopdf: update 0.12.4 -> 0.12.5, unbreak

  - take maintainer

  PR:		228968, 228732
  Submitted by:	truckman, pi
  Reviewed by:	Ashish Kulkarni <kulkarni.ashish@gmail.com> (upstream)
  Approved by:	mm (maintainer)
  Relnotes:	https://github.com/wkhtmltopdf/wkhtmltopdf/releases

Changes:
  head/converters/wkhtmltopdf/Makefile
  head/converters/wkhtmltopdf/distinfo
  head/converters/wkhtmltopdf/files/patch-clientcert
  head/converters/wkhtmltopdf/files/patch-src_3rdparty_webkit_Source_WebCore_html_HTMLImageElement.cpp
  head/converters/wkhtmltopdf/pkg-plist
Comment 2 Kurt Jaeger freebsd_committer 2018-06-13 05:24:46 UTC
Committed, thanks!