Bug 228747 - net-mgmt/aircrack-ng: GCC requirement?
Summary: net-mgmt/aircrack-ng: GCC requirement?
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Lars Engels
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-04 16:47 UTC by Michael Danilov
Modified: 2018-06-21 08:01 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (lme)


Attachments
poudriere testport with "USE_GCC" commented out. (185.17 KB, text/plain)
2018-06-04 16:51 UTC, Michael Danilov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Danilov 2018-06-04 16:47:21 UTC
Why does it require GCC 7.0+ when it builds (and seems to work) fine with clang? 

I, personally, am tired of waiting for ten versions of the same compiler to build each time I update the system.
Comment 1 Michael Danilov 2018-06-04 16:48:42 UTC
(or at least on 11.1-RELEASE-p10)
Comment 2 Michael Danilov 2018-06-04 16:51:09 UTC
Created attachment 194002 [details]
poudriere testport with "USE_GCC" commented out.
Comment 3 Lars Engels freebsd_committer 2018-06-11 12:51:00 UTC
Thanks for your feedback!

I should have added the reason for this to the last commit message.
aircrack-ng builds fine with clang, but according to the upstream developers the GCC built version runs much faster:

" * For best performance on FreeBSD (50-70% more), install gcc5 (or better) via: pkg install gcc7"

Source: https://github.com/aircrack-ng/aircrack-ng/blob/master/INSTALLING

I will change the default GCC to version 6, though, so the default gcc is chosen.
Comment 4 commit-hook freebsd_committer 2018-06-21 08:00:04 UTC
A commit references this bug:

Author: lme
Date: Thu Jun 21 07:59:02 UTC 2018
New revision: 472962
URL: https://svnweb.freebsd.org/changeset/ports/472962

Log:
  net-mgmt/aicrack-ng:

  - Set required GCC version to 6+, so that the default gcc version is chosen.
  GCC isn't needed to successfully building the port, but according to upstream
  using the gcc compiled version is 60-70% faster than the clang compiled
  version.
  - Bump PORTREVISION

  PR:		228747
  Submitted by:	Michael Danilov <mike.d.ft402@gmail.com>

Changes:
  head/net-mgmt/aircrack-ng/Makefile