Bug 228752 - finance/kmymoney patch-kmymoney_dialogs_transactioneditor.cpp breaks kmymoney
Summary: finance/kmymoney patch-kmymoney_dialogs_transactioneditor.cpp breaks kmymoney
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason E. Hale
Depends on:
Reported: 2018-06-04 20:19 UTC by Peter
Modified: 2018-06-14 06:47 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (jhale)

Kmymoney crash fix (2.68 KB, patch)
2018-06-04 22:27 UTC, Jason E. Hale
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter 2018-06-04 20:19:48 UTC
Long history can be found here:

but what I've found is when I compile 5.0.1 via ports [or pkg install], as soon as I click on any transaction and then hit edit or new, kmymoney crashes.

If I remove the patch and recompile, all seems to be working fine;

za:# svn stat
D       files/patch-kmymoney_dialogs_transactioneditor.cpp

I can edit transactions, I can add new transactions.
Not sure what it was supposed to fix, but it sure broke kmymoney for me.
Comment 1 Jason E. Hale freebsd_committer 2018-06-04 22:27:21 UTC
Created attachment 194005 [details]
Kmymoney crash fix

The patch in the ports tree was trying to fix a crash when clicking the "New Schedule..." button in Scheduled Transactions. Totally unpatched, kmymoney 5.0.1 still seems to crash adding a new schedule or editing a transaction.

Thomas' patch in the KDE bug 392735 you referenced seems to fix both issues for me. (https://bugsfiles.kde.org/attachment.cgi?id=113032)

Does the attached patch work for you?
Comment 2 Peter 2018-06-04 23:22:27 UTC
Just deleting 
and building kmymoney 5.0.1 from ports, I'm able to edit transactions, create new transactions.  

I'm also able to create 'New Schedule' by clicking on that button.

With files/patch-kmymoney_dialogs_transactioneditor.cpp, I was not able to edit, or create new transactions.  I was able to only 'Enter Schedule' for a pre existing Scheduled transaction.

za:$ svn stat /usr/ports/
D       /usr/ports/finance/kmymoney/files/patch-kmymoney_dialogs_transactioneditor.cpp

I tried kmymoney from git [master], kde.org patches as suggested, and this ports patch - it would still core dump on any transaction edit/new I tried to do.  

kmymoney from git [master], kde.org patches as suggested, and without this ports patch it worked.

kmymoney from ports [5.0.1], without kde.org patches, and without this ports patch it works.

working kmymoney from ports:
za:$ svn stat /usr/ports/
D       /usr/ports/finance/kmymoney/files/patch-kmymoney_dialogs_transactioneditor.cpp
Comment 3 commit-hook freebsd_committer 2018-06-05 21:52:51 UTC
A commit references this bug:

Author: jhale
Date: Tue Jun  5 21:51:55 UTC 2018
New revision: 471825
URL: https://svnweb.freebsd.org/changeset/ports/471825

  Fix crash when editing or adding new transactions

  PR:		228752
  Submitted by:	Peter <fbsdq@peterk.org>
  Obtained from:	https://bugs.kde.org/show_bug.cgi?id=392735