Bug 228779 - www/node: useless patch applied
Summary: www/node: useless patch applied
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bradley T. Hughes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-06 08:48 UTC by Sylvain Garrigues
Modified: 2018-06-08 18:44 UTC (History)
0 users

See Also:
bhughes: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sylvain Garrigues 2018-06-06 08:48:15 UTC
It seems to me that freebsd-ports/www/node/files/patch-deps_v8_src_base_cpu.cc is wrong since there is already an +#if V8_OS_LINUX enclosing the inserted one.
Comment 1 Bradley T. Hughes freebsd_committer 2018-06-08 04:40:46 UTC
Yes, indeed, good catch! I will fix the patch when committing the upgrade to Node.js v10.4.0.

Thanks! :)
Comment 2 Bradley T. Hughes freebsd_committer 2018-06-08 18:43:37 UTC
Committed, thanks! :)
Comment 3 commit-hook freebsd_committer 2018-06-08 18:44:06 UTC
A commit references this bug:

Author: bhughes
Date: Fri Jun  8 18:43:12 UTC 2018
New revision: 472018
URL: https://svnweb.freebsd.org/changeset/ports/472018

Log:
  www/node: Update 10.3.0 -> 10.4.0

  https://nodejs.org/en/blog/release/v10.4.0/

  Remove files/patch-deps_v8_src_base_cpu.cc, which has been applied
  upstream and is no longer necessary (as reported in PR 228779). Other
  patches have been refreshed as needed with `make makepatch`.

  PR:		228779
  Reported by:	Sylvain Garrigues <sylvain@sylvaingarrigues.com>
  Sponsored by:	Miles AS

Changes:
  head/www/node/Makefile
  head/www/node/distinfo
  head/www/node/files/patch-deps_v8_src_base_cpu.cc
  head/www/node/files/patch-node.gypi