It seems to me that freebsd-ports/www/node/files/patch-deps_v8_src_base_cpu.cc is wrong since there is already an +#if V8_OS_LINUX enclosing the inserted one.
Yes, indeed, good catch! I will fix the patch when committing the upgrade to Node.js v10.4.0.
Committed, thanks! :)
A commit references this bug:
Date: Fri Jun 8 18:43:12 UTC 2018
New revision: 472018
www/node: Update 10.3.0 -> 10.4.0
Remove files/patch-deps_v8_src_base_cpu.cc, which has been applied
upstream and is no longer necessary (as reported in PR 228779). Other
patches have been refreshed as needed with `make makepatch`.
Reported by: Sylvain Garrigues <email@example.com>
Sponsored by: Miles AS