Bug 228800 - Redundant code in contrib/tzcode/stdtime/private.h
Summary: Redundant code in contrib/tzcode/stdtime/private.h
Status: Closed Overcome By Events
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Philip Paeps
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-06-07 09:53 UTC by Tim McNamara
Modified: 2024-02-15 09:28 UTC (History)
2 users (show)

See Also:

Attachments
Removes redundant lines (1011 bytes, patch)
2018-06-07 09:57 UTC, Tim McNamara 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim McNamara 2018-06-07 09:53:01 UTC 
Lines 224..240 of contrib/tzcode/stdtime/private.h appear to contain the same code twice:


/*
** Since the definition of TYPE_INTEGRAL contains floating point numbers,
** it cannot be used in preprocessor directives.
*/

#ifndef TYPE_INTEGRAL
#define	TYPE_INTEGRAL(type) (((type) 0.5) != 0.5)
#endif /* !defined TYPE_INTEGRAL */

/*
** Since the definition of TYPE_INTEGRAL contains floating point numbers,
** it cannot be used in preprocessor directives.
*/

#ifndef TYPE_INTEGRAL
#define TYPE_INTEGRAL(type) (((type) 0.5) != 0.5)
#endif /* !defined TYPE_INTEGRAL */
Comment 1 Tim McNamara 2018-06-07 09:57:44 UTC 
Created attachment 194061 [details]
Removes redundant lines
Comment 2 Philip Paeps freebsd_committer freebsd_triage 2019-05-22 15:21:07 UTC 
Our tzcode is getting a little long in the tooth.  I have a long-standing work in progress to update it.  I would be surprised if this bug were still present in more recent versions of tzcode.

I'll try to get around to finishing the merge of a newer tzcode Soon[tm].

(Note that our tzdata is in sync with upstream -- only tzcode is stale.)
Comment 3 Allan Jude freebsd_committer freebsd_triage 2020-06-24 20:15:07 UTC 
(In reply to Philip Paeps from comment #2)
Did you ever get back tho this?
Comment 4 Philip Paeps freebsd_committer freebsd_triage 2020-07-30 04:17:03 UTC 
Thanks for the reminder.  I haven't had a chance to look at this since last year.  I'll see if I can pick this up again.
Comment 5 Philip Paeps freebsd_committer freebsd_triage 2024-02-15 09:28:16 UTC 
Our tzcode has seen recent love from des@.  The most recent imports do not include this duplicate code.  Marking this issue as overcome by events.