Bug 228820 - Incorrect value of ARG_TERMID_ADDR in sys/security/audit/audit.h
Summary: Incorrect value of ARG_TERMID_ADDR in sys/security/audit/audit.h
Status: In Progress
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Alan Somers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-08 03:39 UTC by Aniket Pandey
Modified: 2018-06-13 14:55 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aniket Pandey 2018-06-08 03:39:23 UTC
The definition of "ARG_TERMID_ADDR" macro assigns it a value of

0x0000000000400000ULL

which is already assigned to "ARG_SADDRUNIX" a line above.

This change was accidentally introduced in rS168688.
https://reviews.freebsd.org/rS168688


Please See: https://github.com/freebsd/freebsd/blob/7c423a65c91bf1b002e8f1f6f0f8bfa9beefcc9c/sys/security/audit/audit_private.h#L278
Comment 1 commit-hook freebsd_committer 2018-06-13 14:55:48 UTC
A commit references this bug:

Author: asomers
Date: Wed Jun 13 14:55:32 UTC 2018
New revision: 335060
URL: https://svnweb.freebsd.org/changeset/base/335060

Log:
  audit(4): fix the definition of ARG_TERMID_ADDR

  Due to a copy/paste error in r168688, ARG_TERMID_ADDR has the same
  definition as ARG_SADDRUNIX.  Fix it.

  The header change, while publicly visible, is guarded by #ifdef KERNEL, and
  I can't find any kmod ports that use it.  So I'm not bumping
  __FreeBSD_version.

  PR:		228820
  Submitted by:	aniketp
  Sponsored by:	Google, Inc. (GSoC 2018)
  Differential Revision:	https://reviews.freebsd.org/D15702

Changes:
  head/sys/security/audit/audit_private.h