Bug 228902 - devel/qca: Fails to build with OpenSSL 1.1
Summary: devel/qca: Fails to build with OpenSSL 1.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: kde
URL:
Keywords:
Depends on:
Blocks: 228865 231931
  Show dependency tree / graph
 
Reported: 2018-06-11 19:41 UTC by Bernard Spil
Modified: 2018-10-12 09:20 UTC (History)
3 users (show)

See Also:
tcberner: maintainer-feedback+

Attachments
v1 (1.45 KB, patch)
2018-06-12 04:56 UTC, Tobias C. Berner 		no flags Details | Diff
Fix OpenSSL 1.x build (61.21 KB, patch)
2018-10-07 19:01 UTC, Nathan 		ndowens: maintainer-approval? (tcberner)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Spil freebsd_committer 2018-06-11 19:41:06 UTC 
incomplete type 'DSA_SIG'

During BSDCan 2018 the intention to update OpenSSL in base to 1.1.x branch was documented.

Intention is to update 12-STABLE to current 1.1.0 and subsequently update it to 1.1.1 when that is released. 

Poudriere log: https://keg.brnrd.eu/data/111amd64-default-openssl110/2018-06-11_10h42m37s/logs/errors/qca-qt5-2.1.3_1.log
Comment 1 Tobias C. Berner freebsd_committer 2018-06-12 04:28:02 UTC 
We can import the upstream commit:

https://github.com/KDE/qca/commit/d58e20ee652038dc4ec4fe4765dc3639ed735526
Comment 2 Tobias C. Berner freebsd_committer 2018-06-12 04:56:23 UTC 
Created attachment 194185 [details]
v1

Here's a quick update to the port to the tag containing the patch... [-qt4 is broken by this...]


mfg Tobias
Comment 3 Tobias C. Berner freebsd_committer 2018-06-12 05:01:00 UTC 
Sorry, looked at the output wrong :) 10.4 is broken
Comment 5 Nathan 2018-10-07 18:48:36 UTC 
Got this one working, just got to get it to where both openssl-base and openssl-devel+ works
Comment 6 Nathan 2018-10-07 19:01:33 UTC 
Created attachment 197883 [details]
Fix OpenSSL 1.x build

 devel/qca:
 
 * Fix OpenSSL 1.1.x build
 * Add License, while here
 
 PR:             228902
 Submitted by:   Nathan <ndowens@yahoo.com>
Comment 7 commit-hook freebsd_committer 2018-10-11 19:57:05 UTC 
A commit references this bug:

Author: adridg
Date: Thu Oct 11 19:56:48 UTC 2018
New revision: 481850
URL: https://svnweb.freebsd.org/changeset/ports/481850

Log:
  Fix devel/qca with OpenSSL 1.1.1.

  Contains portions extracted from upstream and portions created by
  submitter. Upstream bits are marked with their git hash.

  PR:		228902
  Submitted by:	Nathan <ndowens@yahoo.com>
  Reported by:	brnrd

Changes:
  head/devel/qca/Makefile
  head/devel/qca/files/
  head/devel/qca/files/patch-git_e854f357
  head/devel/qca/files/patch-plugins_qca-ossl_libcrypto-compat.c
  head/devel/qca/files/patch-plugins_qca-ossl_libcrypto-compat.h
  head/devel/qca/files/patch-plugins_qca-ossl_qca-ossl.cpp
Comment 8 Adriaan de Groot freebsd_committer 2018-10-12 09:20:07 UTC 
Tests pass in 12-(openssl111) and 11.1 amd64, for both flavors, so I consider this fixed.