Bug 228904 - x11-toolkits/wxgtk31: add gtk3 flavor
Summary: x11-toolkits/wxgtk31: add gtk3 flavor
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-11 19:54 UTC by Greg V
Modified: 2018-06-12 10:38 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
wx31-gtk3.patch (8.28 KB, patch)
2018-06-11 19:54 UTC, Greg V
no flags Details | Diff
wx-mk-flavors.patch (1.21 KB, patch)
2018-06-11 19:56 UTC, Greg V
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg V 2018-06-11 19:54:49 UTC
Created attachment 194177 [details]
wx31-gtk3.patch

Flavorized the port + fixed Makefile.in to make the wx-config name full like it is in the 3.0 port instead of just 'wx-config'.
Unfortunately, still can't parallel-install the two flavors because of the headers...

Some app testing: poedit works fine, treesheets works fine, hugin works only on X11 (does raw GdkX11Display stuff, invalid cast on GdkWaylandDisplay), kicad kinda works (with python disabled; some tools look broken), veracrypt works with skippable assertion failure dialogs
Comment 1 Greg V 2018-06-11 19:56:16 UTC
Created attachment 194179 [details]
wx-mk-flavors.patch

+ here's a patch for bsd.wx.mk
Comment 2 Yuri Victorovich freebsd_committer 2018-06-11 20:07:16 UTC
Greg,

Why do you want to support gtk2? It is the older version, superseded by gtk3.
My concern is associated maintenance cost without much sensible benefit.

Yuri
Comment 3 Greg V 2018-06-11 20:13:17 UTC
(In reply to Yuri Victorovich from comment #2)
Not all applications work well with gtk3...

Compare "Required By" in
https://www.archlinux.org/packages/extra/x86_64/wxgtk2/
vs
https://www.archlinux.org/packages/extra/x86_64/wxgtk3/

I guess the dev version (3.1) can be gtk3 only, but stable would need both for sure.
Comment 4 Yuri Victorovich freebsd_committer 2018-06-11 20:28:53 UTC
(In reply to Greg V from comment #3)

These "Required By" are possibly just due to the choice of the gtk2 version in Arch AUR ports. How many of them really require gtk2 and can't work with gtk3?

Yuri
Comment 5 Greg V 2018-06-11 20:36:06 UTC
(In reply to Yuri Victorovich from comment #4)
kicad is definitely broken in many places...
Comment 6 Yuri Victorovich freebsd_committer 2018-06-11 20:40:58 UTC
Ok, I will study this issue how needed gtk2 support really is.
Please note that if some ports aren't gtk3 compatible they can also stay on wx28 or wx30 for the time being.

Mk certainly needs 3.1 added.

Thank you, Greg, for the patch.
I will see what to do next.
Comment 7 Yuri Victorovich freebsd_committer 2018-06-11 20:45:32 UTC
And, like you said, there is no easy way to install @gtk2 and @gtk3 flavors at the same time, so this would certainly cause conflicts.
Comment 8 commit-hook freebsd_committer 2018-06-12 07:17:53 UTC
A commit references this bug:

Author: yuri
Date: Tue Jun 12 07:17:11 UTC 2018
New revision: 472232
URL: https://svnweb.freebsd.org/changeset/ports/472232

Log:
  x11-toolkits/wxgtk31: Change to gtk3 because it is the latest gtk version

  Also remove the stray file wxmsw.mo that caused conflict with wxgtk30.

  This patch is a portion of the patch from the bug#228904.

  PR:		228904
  Submitted by:	Greg V <greg@unrelenting.technology>

Changes:
  head/x11-toolkits/wxgtk31/Makefile
  head/x11-toolkits/wxgtk31/files/patch-Makefile.in
  head/x11-toolkits/wxgtk31/pkg-plist