228981 – sysutils/py-salt: fix sysctl.present on FreeBSD

Bug 228981 - sysutils/py-salt: fix sysctl.present on FreeBSD

Summary: sysutils/py-salt: fix sysctl.present on FreeBSD

Status:	Closed Overcome By Events

Alias:	None

Product:	Ports & Packages
Classification:	Unclassified
Component:	Individual Port(s) (show other bugs)
Version:	Latest
Hardware:	Any Any

Importance:	--- Affects Only Me
Assignee:	Mathieu Arnold

URL:
Keywords:

Depends on:
Blocks:

Reported:	2018-06-13 12:04 UTC by Mathieu Arnold
Modified:	2019-04-30 13:17 UTC (History)
CC List:	3 users (show)

See Also:

Flags:	bugzilla: maintainer-feedback? (christer.edwards)

Attachments
v1 (1.53 KB, patch) 2018-06-13 12:04 UTC, Mathieu Arnold	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mathieu Arnold freebsd_committer

2018-06-13 12:04:42 UTC

Created attachment 194220 [details]
v1

In b3c1be27fb the lines were stripped of their ending \n, but the \n was never added back to the lines, so calling writelines generates a broken one line file.

Comment 1 Christer Edwards 2018-06-14 15:02:43 UTC

This patch is addressed in the 2018.3.1 upgrade patch over here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229012

Comment 2 Sven Ruediger 2019-02-04 13:17:45 UTC

fix has been merged upstream (already present in current port)

https://github.com/saltstack/salt/commit/56c87ff6900bde45f01966b61fb87c665f4505f8#diff-3b24aaef4af6bf0d0d3023669f16a870
https://github.com/saltstack/salt/pull/48087