Bug 229010 - devel/pijul: Unbreak on i386
Summary: devel/pijul: Unbreak on i386
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlo Strub
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-06-14 11:21 UTC by Tobias Kortkamp
Modified: 2018-06-14 20:18 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (cs)


Attachments
pijul.diff (1.68 KB, patch)
2018-06-14 11:21 UTC, Tobias Kortkamp
tobik: maintainer-approval? (cs)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2018-06-14 11:21:03 UTC
Created attachment 194246 [details]
pijul.diff

Pijul currently fails to build on i386 [1,2] with

error[E0308]: mismatched types
 --> line/src/unix.rs:9:27
  |
9 |         if libc::ioctl(1, libc::TIOCGWINSZ as u64, &mut size) == 0 {
  |                           ^^^^^^^^^^^^^^^^^^^^^^^ expected u32, found u64

line >= 0.1.3 fixes this by using libc::c_ulong instead of u64, so to fix the
build we could manually patch this or bump the line crate to the latest
version 0.1.7.

[1] https://lists.freebsd.org/pipermail/freebsd-pkg-fallout/Week-of-Mon-20180611/805169.html
[2] https://lists.freebsd.org/pipermail/freebsd-pkg-fallout/Week-of-Mon-20180611/805175.html
Comment 1 Carlo Strub freebsd_committer 2018-06-14 20:18:01 UTC
committed. thanks a lot!
Comment 2 commit-hook freebsd_committer 2018-06-14 20:18:11 UTC
A commit references this bug:

Author: cs
Date: Thu Jun 14 20:17:43 UTC 2018
New revision: 472396
URL: https://svnweb.freebsd.org/changeset/ports/472396

Log:
  Unbreak i386

  PR:		229010
  Submitted by:	tobik@

Changes:
  head/devel/pijul/Makefile
  head/devel/pijul/distinfo