Created attachment 194365 [details] svn diff for sysutils/bbcp pkg-fallout has been complaining about attempted builds of sysutils/bbcp failing. This pr(1) attempts to fix that, as well as some other issues related to the port; portlint complaints && users reporting difficulty understanding how use it ( bug #197035 ). Changes Makefile Removes files/patch-src__bbcp_Args.C files/patch-src__bbcp_BuffPool.C files/patch-src__bbcp_Config.C files/patch-src__bbcp_File.C files/patch-src__bbcp_FileSpec.C files/patch-src__bbcp_NetAddr.C files/patch-src__bbcp_NetAddrInfo.C files/patch-src__bbcp_Node.C files/patch-src__bbcp_ProcMon.C files/patch-src__bbcp_ProgMon.C files/patch-src__bbcp_Protocol.C files/patch-src__bbcp_Pthread.C files/patch-src__bbcp_Pthread.h files/patch-src__bbcp_Stream.C files/patch-src__bbcp_System.C files/patch-src__bbcp_ZCX.C Adds files/patch-src_bbcp_Args.C files/patch-src_bbcp_BuffPool.C files/patch-src_bbcp_Config.C files/patch-src_bbcp_File.C files/patch-src_bbcp_FileSpec.C files/patch-src_bbcp_NetAddr.C files/patch-src_bbcp_NetAddrInfo.C files/patch-src_bbcp_Node.C files/patch-src_bbcp_ProcMon.C files/patch-src_bbcp_ProgMon.C files/patch-src_bbcp_Protocol.C files/patch-src_bbcp_Pthread.C files/patch-src_bbcp_Pthread.h files/patch-src_bbcp_Stream.C files/patch-src_bbcp_System.C files/patch-src_bbcp_ZCX.C files/FREEBSDUSERS svn diff, as well as QA LOG attached. Thanks! --Chris
Created attachment 194367 [details] QA LOG for sysutils/bbcp QA LOG to prove it builds on 12-CURRENT There are still some warnings. But I've now got a more recent version of source, and will be using it for future version(s) of this port. Consider this one a stop-gap until I can release the newer version. Thanks! --Chris
bump. almost a month now. :-)
The patch failed to apply automatically for me due to the paths not including the category, and after applying it manually, the port fails to build: --- ../obj/FreeBSD/bbcp_Protocol.o --- bbcp_Protocol.C:928:51: error: non-constant-expression cannot be narrowed from type 'int' to 'size_t' (aka 'unsigned long') in initializer list [-Wc++11-narrowing] {(char *)" ", 1}, {csVal, csVsz}, ^~~~~ bbcp_Protocol.C:928:51: note: insert an explicit cast to silence this issue {(char *)" ", 1}, {csVal, csVsz}, ^~~~~ static_cast<size_t>( ) 1 error generated. Also, in files/FREEBSDUSERS there are so "space at end of line" issues and one of the hyphens in a command line option is UTF-8.
To submitter: I am getting bounces from your email address.
(In reply to Mark Linimon from comment #4) > To submitter: I am getting bounces from your email address. sorry. I'm running pf(1) on the MX, and it appears to be hitting it's upper limit. If you're receiving outright REJECTS. I apologize. I have pretty strict rules in place. As just submitting this reply will result in no less than fifty attempts to SPAM my registered address here. :-( As memory serves; your domain is lonesome (com). which appears to have soaustin (net) serve as it's MX. I've whitelisted both. :-) Thanks for letting me know, and sorry for the inconvenience! --Chris OH, and I should be able to update the previously submitted patch w/in the next couple days.
Any updates on this one? I offer my helping hand, if needed.
(In reply to Vinca Kol from comment #6) Help would be good if you care about this port. The maintainer seems to be MIA and the port has been marked as broken since ports r484017.
Created attachment 200359 [details] New patch I reworked Chris' patch. This one builds on {11.2,12.0}{i386,amd64} and 13-CURRENT i386. However, I can not make it work. I tried to transfer a file in the same computer and it segfaulted. bbcp: Accept timed out on port 5031 bbcp: Unable to allocate more than 0 of 4 data streams. I didn't look to much into the doc. Maybe the maintainer can help here?
Created attachment 200361 [details] patch v2 This one corrects the encoding of the file/FREEBSDUSERS file
Created attachment 200482 [details] Clean build on 12-STABLE I took up the offer (in PR 197035) of looking at this and fixing it myself. I have bbcp 17.12.00.00.0 (that's the latest from the author's GIT) working on FreeBSD 12-STABLE as the initiator of the transfer, using IPv4, without needing the -4 flag or changing the sysctl. It also compiles cleanly on 12-stable with no warnings or other noise (see attached log). It is still not working as a target, but I wanted to report my progress (substantial, IMHO) in case other people are working on this using older code and patches. This latest version has the useful side effect of no longer needing the vast majority of patches in the FreeBSD port - all of the patches to change "if (foo)" to "if ((foo))" have been upstreamed. All of my work so far is available if anyone wants to take this over. My next task will be getting the receive side working in this version, then testing the various IPv6 permutations. Here's the test run: [0:54] host1:~> bbcp --version 17.12.00.00.0 [0:55] host1:~> sysctl net.inet6.ip6.v6only net.inet6.ip6.v6only: 1 [0:56] host1:~> bbcp -P 2 /dev/zero host2.example.com:/dev/null Unauthorized Access Strictly Prohibited Password for terry@host2.example.com: bbcp: Warning: host1.example.com is running a newer version of bbcp bbcp: Creating /dev/null/zero bbcp: 181225 01:35:54 0% done; 117.1 MB/s bbcp: 181225 01:35:56 0% done; 117.4 MB/s ^C
(In reply to Terry Kennedy from comment #10) Hi Terry, Could you attach a svn diff so I can test it builds too in 11.2 and 13-CURRENT? Thanks!
Created attachment 200542 [details] Replacement port files
(In reply to Fernando Apesteguía from comment #11) Grrr... Bugzilla discards comments entered before you click on "Add an attachment". Let's try again... (In reply to Fernando Apesteguía from comment #11) At the moment it isn't working as well as what is currently in ports (it can send but not receive) so I wouldn't import it yet. I'm attaching a tarfile which completely replaces the current bbcp port (just rename the old one to something like bbcp-old before unpacking this one). It is a work-in-progress - I'll submit real diffs once I have something more complete to show. You'll also need to check out the latest version from the author's git: git clone http://www.slac.stanford.edu/~abh/bbcp/bbcp.git
(In reply to Terry Kennedy from comment #13) > It is a work-in-progress - I'll submit real diffs once I have something more complete to show. Any news? The port has expired on 2019-05-08. This PR is probably the only reason it has not been removed yet.
The developer of BBCP stopped responding to emails back during the government shutdown, and I've been off doing other things (I only got back yesterday from a month and a half off-net). I'll send him a note to see if he has the time to work with me on it. Alternatively, it would be fine to remove the port and I can submit a new one once / if I get it working 100%.
Note That for any proposed changes, we need: - A unified diff against ports head - QA tested (portlint, poudriere) on all supported versions/archs (tier 1)
We are about three months after the port expiration date, it's probably time to take a decision. Can we close this PR and remove the broken version of the port ? We can also close #197035. @Chris Hutchinson: need your approval to proceed :)
(In reply to Rodrigo Osorio from comment #17) > @Chris Hutchinson: need your approval to proceed :) Chris's last comment was comment #5 and we have waited for >1 year for feedback for everything raised after that. Please just proceed.
A commit references this bug: Author: rodrigo Date: Sat Aug 3 11:45:42 UTC 2019 New revision: 507966 URL: https://svnweb.freebsd.org/changeset/ports/507966 Log: Remove expired sysutils/bbcp The port was reported broken one year ago, and no acceptable fix was provide in the meantime. An expiration date was set 4 months ago, and now it's time to proceed and remove it. PR: 229115 Changes: head/MOVED head/sysutils/Makefile head/sysutils/bbcp/
Since the expiration date was reached months ago, and without acceptable fix, and after a timeout period this port is now removed.