Bug 229248 - databases/rocksdb: Add RTTI option
Summary: databases/rocksdb: Add RTTI option
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Walter Schwarzenfeld
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-23 09:59 UTC by Andreas Sommer
Modified: 2019-08-09 08:32 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
Makefile change to add RTTI option, default off (873 bytes, patch)
2018-06-23 09:59 UTC, Andreas Sommer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sommer 2018-06-23 09:59:55 UTC
Created attachment 194531 [details]
Makefile change to add RTTI option, default off

The "full" package did not have the option to enable RTTI support, while the `rocksdb-lite` package had it turned on by default (strange for a "lite" version because it increases size). This patch turns both into an option, defaulting to off. Feel free to adapt if the lite version had an urgent requirement on RTTI for some reason that was not documented in the port.
Comment 1 Andreas Sommer 2018-06-23 10:19:45 UTC
Note: I guess this needs a revision bump (not part of my patch).
Comment 2 Sunpoet Po-Chuan Hsieh freebsd_committer 2018-06-24 20:31:29 UTC
lx@ (maintainer of rocksdb-lite) is Cc'd.

rocksdb-lite was added to the ports tree as a dependency of sysutils/osquery. And osquery is the only consumer which requires RTTI. That's why RTTI was only enabled in rocksdb-lite.
Comment 3 David Thiel freebsd_committer 2018-06-25 19:00:03 UTC
I'll doublecheck with the devs, but last I checked, rocksdb-lite does still require RTTI (not to build, but because of some subtle bugs). So if you want to commit this soon, let's make it so that it continues to default to on for -lite. Will update if I hear anything different from the devs.
Comment 4 Sunpoet Po-Chuan Hsieh freebsd_committer 2018-06-25 19:38:59 UTC
I'm not going to commit this. I just explain the reason why RTTI is enabled in rocksdb-lite.
Comment 5 Andreas Sommer 2018-07-04 10:03:49 UTC
I'm fine to keep compatibility for -lite, i.e.

.if !defined(LITE)
# ...
.else
OPTIONS_DEFAULT+=	RTTI
# ...
.endif

and probably put in a comment for the reason.

Anything speaking against committing the new option in this backward-compatible fashion?
Comment 6 Walter Schwarzenfeld freebsd_triage 2019-08-08 19:33:48 UTC
ping!