Bug 229271 - graphics/ufraw: fails to build requires a space between literal and identifier
Summary: graphics/ufraw: fails to build requires a space between literal and identifier
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-24 11:34 UTC by Walter Schwarzenfeld
Modified: 2018-07-01 21:44 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (rodrigo)


Attachments
svn-diff-ufraw (2.46 KB, patch)
2018-06-24 11:34 UTC, Walter Schwarzenfeld
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Walter Schwarzenfeld freebsd_triage 2018-06-24 11:34:01 UTC
Created attachment 194557 [details]
svn-diff-ufraw

Details see:
https://lists.freebsd.org/pipermail/freebsd-ports/2018-June/113693.html
Comment 1 Walter Schwarzenfeld freebsd_triage 2018-06-24 13:54:12 UTC
I make the /patch-ufraw__developer.c	 cause the abs/fabs error cause on some platforms errors (here it was only a warning).
Comment 2 Kurt Jaeger freebsd_committer 2018-06-24 14:24:36 UTC
testbuilds look fine.
Comment 3 commit-hook freebsd_committer 2018-07-01 21:43:15 UTC
A commit references this bug:

Author: rodrigo
Date: Sun Jul  1 21:42:50 UTC 2018
New revision: 473684
URL: https://svnweb.freebsd.org/changeset/ports/473684

Log:
  Fix graphics/ufraw build for 12.0

  Fix code issues who causes build failures
  due to missing spaces between literal and identifier.

  Bump PORTREVISION.

  PR:		229271
  Submitted by:	<w.schwarzenfeld@utanet.at>

Changes:
  head/graphics/ufraw/Makefile
  head/graphics/ufraw/files/patch-dcraw.cc
  head/graphics/ufraw/files/patch-ufraw__developer.c
Comment 4 Rodrigo Osorio freebsd_committer 2018-07-01 21:44:14 UTC
Committed, thanks for the bug report.