Bug 229395 - www/webkit2-gtk3 -2.20.3 fails to build on armv7
Summary: www/webkit2-gtk3 -2.20.3 fails to build on armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-28 19:16 UTC by Ulrich Grey
Modified: 2018-11-10 03:39 UTC (History)
4 users (show)

See Also:
pi: maintainer-feedback-

Attachments
patch (1.16 KB, patch)
2018-07-02 09:46 UTC, Mikael Urankar 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Grey 2018-06-28 19:16:02 UTC 
It's a native build on a wandboard-quad running FreeBSD 12.0-CURRENT #0 r333645

[2077/3027] ...
In file included from DerivedSources/WebCore/unified-sources/UnifiedSource345.cpp:1:
/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.20.3/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.cpp:38:8: error: an attribute list cannot appear here
static alignas(16) short s_FELightingConstantsForNeon[] = {
       ^~~~~~~~~~~
1 error generated.

Please see the poudriere build log:
http://ulrich-grey.de/dl/FreeBSD/webkit2-gtk3-2.20.3.log
Comment 1 Walter Schwarzenfeld freebsd_triage 2018-06-29 02:17:43 UTC 
=> alignas(16) static short....
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2018-07-02 09:46:17 UTC 
Created attachment 194831 [details]
patch

Can you try the attached patch?
obtained from: mmel@
Comment 3 Ulrich Grey 2018-07-03 15:25:12 UTC 
(In reply to mikael.urankar from comment #2)
I have applied the patch.
The build now finished successfully.
Please see the build log:

http://ulrich-grey.de/dl/FreeBSD/patched_webkit2-gtk3-2.20.3.log
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2018-11-10 03:39:01 UTC 
Committed, thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-11-10 03:39:21 UTC 
A commit references this bug:

Author: pi
Date: Sat Nov 10 03:38:48 UTC 2018
New revision: 484569
URL: https://svnweb.freebsd.org/changeset/ports/484569

Log:
  www/webkit2-gtk3: fix build on armv7

  PR:		229395
  Submitted by:	Mikael Urankar <mikael.urankar@gmail.com>
  Reported by:	Ulrich Grey <usenet@ulrich-grey.de>

Changes:
  head/www/webkit2-gtk3/files/patch-Source_WebCore_platform_graphics_cpu_arm_filters_FELightingNEON.cpp