Created attachment 194712 [details]
New port for frr5
Please comment if you want to be the maintainer 8-}
Needs testbuilds, run-tests.
Thanks, I had a FRR 5.0 port on my workstation too, but still didn't committed because FRR 4.0 had regressions and I need to be sure was fixed on FRR 5.0:
- https://github.com/FRRouting/frr/issues/2338 (tun/gre/)
- https://github.com/FRRouting/frr/pull/2355 (SNMP option fixes)
About this shar version, it didn't build because it miss a doc build deps:
gmake: Entering directory '/wrkdirs/usr/ports/net/frr5/work/frr-frr-5.0/doc/manpages'
../frr-sphinx.mk:24: *** "The 'sphinx-1.0-build' command was not found. Make sure you have Sphinx installed, then set the SPHINXBUILD make variable to point to the full path of the 'sphinx-1.0-build' executable. Alternatively you can add the directory with the executable to your PATH. If you don't have Sphinx installed, grab it from http://sphinx-doc.org/". Stop.
gmake: Leaving directory '/wrkdirs/usr/ports/net/frr5/work/frr-frr-5.0/doc/manpages'
gmake: *** [Makefile:719: all-recursive] Error 1
Once this dependencies fixed, there is another problem regarding the plist:
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%ETCDIR%%/pbrd.conf.sample
Error: Orphaned: include/frr/debug.h
Error: Orphaned: include/frr/logicalrouter.h
Error: Orphaned: include/frr/nexthop_group.h
Error: Orphaned: include/frr/pbr.h
Error: Orphaned: man/man8/pbrd.8.gz
Error: Orphaned: sbin/pbrd
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: man/man8/frr-args.8.gz
===> Error: Plist issues found.
These issues are solved on my version, but I still need to:
- fix build with SNMP option
- Test for FRR 4.0 regressions against FRR 5.0
This PR https://github.com/FRRouting/frr/pull/2590/files must fix this:https://github.com/FRRouting/frr/issues/2338 (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228643)
and I know that frr 5.0 have problem with TAB key: https://github.com/FRRouting/frr/issues/2433
this problem fix on master branch: https://github.com/FRRouting/frr/pull/2581/files
This problem is not present in the 4th version of the FRR.
After my regression tests of FRR5:
- The tun/gre/gif/etc. bugs introduced in FRR4 is fixed on FRR5 (but no mention of this fix in the release notes). Any I can back-port these pull-request into the net/frr4 port.
- FRR5 allows to build with the SNMP option now.
I've found a new regression on FRR5:
- There is a bug with IPv6 and ISIS, but I don't think there are lot's of users of these feature mix (https://github.com/FRRouting/frr/issues/2584)
I didn't notice the TAB bug on my side.
My Work-in-progress version here:
Today there was an update.
A commit references this bug:
Date: Fri Jul 6 07:36:10 UTC 2018
New revision: 473998
New port: net/frr5 (5.0.1).
Reported by: pi
Sponsored by: Orange
Fix build with SNMP option.
Reported by: email@example.com
Fix crash with gif/tun/gre interface.
Reported by: firstname.lastname@example.org
Hope this new net/frr5 (5.0.1) will suit you.