Bug 229478 - shells/zsh-antigen : add OPTIONS to support devel/git-lite
Summary: shells/zsh-antigen : add OPTIONS to support devel/git-lite
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2018-07-02 19:10 UTC by Christer Edwards
Modified: 2019-09-23 08:05 UTC (History)
3 users (show)

See Also:
gudfitz: maintainer-feedback+


Attachments
patch (868 bytes, text/plain)
2018-07-02 19:10 UTC, Christer Edwards
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christer Edwards 2018-07-02 19:10:12 UTC
Created attachment 194843 [details]
patch

I couldn't find a Makefile option to support either devel/git or devel/git-lite, so I added a config option.

Happy to discuss; simply didn't want to install more depends than needed.
Comment 1 Victor 2018-07-04 02:39:44 UTC
The port builds with devel/git-lite installed; what is this intended to address?
Comment 2 Christer Edwards 2018-07-04 14:35:05 UTC
I am not able to install shells/zsh-antigen without replacing devel/git-lite with devel/git.


https://gist.github.com/cedwards/25eed09e8391a615aa3e8bcfc3a3dfb2

Am I missing something?
Comment 3 Victor 2018-07-04 15:11:49 UTC
Installing it from pkg when you have git-lite installed will, of course, 
remove the conflicting package. If you install it from the ports tree, it will
find the git executable and move on. This patch wouldn't solve the issue of
respecting user preferences when installed from the official repos, and no
other ports with devel/git dependencies seem to provide these options either.

I think that the only way to properly respect user preferences in this  
case is to remove the git dependency and add 'please install git, git-lite or
your preferred package' to pkg-message but that breaks the idea of packages 
working out of the box.
Comment 4 Steve Wills freebsd_committer 2018-07-04 16:46:51 UTC
(In reply to Victor from comment #3)
Another option at least for now might be to create a slave port, say "zsh-antigen-gitlite" with the option set, then you'd get a zsh-antigen-gitlite package you could install.

The real solution will be when pkg supports requires/provides, but that could do until then.
Comment 5 Tobias Kortkamp freebsd_committer 2019-08-30 11:50:39 UTC
(In reply to Victor from comment #3)
I agree that the most sensible option would be to remove the git dependency
and just add a pkg-message telling users to install their preferred Git port.

The downsides are obvious but adding a bunch of options for each git port is
insane too and does not help package only users.  Creating a bunch of slave
ports just pushes the problem outwards.  If some other port ever needs to
depend on zsh-antigen for whatever reason which slave would it depend on?

However this bug is now over a year old with no movement.  Maybe it's no
longer relevant and we can close?  Or will somebody submit a complete patch?