Created attachment 194856 [details]
dhcpd nopf patch
Current net/dhcpd port has no options defined. There is request to be able to compile the port if PF is not part of the base system.
(In reply to Nikola Kolev from comment #0)
Why does this patch remove the USERS and GROUPS lines? Is that somehow required to build without pf support?
As far as I recall, only isc-dhcpd uses the dhcpd user.
dhcpd from OpenBSD uses the base system _dhcp user as seen below:
_dhcp 16854 0.0 0.0 8916 5196 - Is 14Jun18 0:05.53 /usr/local/sbin/dhcpd igb0
Unless there is a specific reason to keep the dhcpd user installed?
It isn't used anywhere for net/dhcpd.
Adding USERS and GROUPS was mistake while creating the port. The daemon is using the default "_dhcp" user.
src/usr.sbin/dhcpd/dhcpd.c: if ((pw = getpwnam("_dhcp")) == NULL)
Removing them from the Makefile is simply clean up.
Thanks to Dries for pointing this out.
A commit references this bug:
Date: Wed Jul 4 14:21:08 UTC 2018
New revision: 473889
net/dhcpd: Add option to disable PF support
While here, remove unneeded USERS and GROUPS lines.
Submitted by: Nikola Kolev <email@example.com> (maintainer)