Bug 229490 - net/dhcpd: Add option 'Disable PF support'
Summary: net/dhcpd: Add option 'Disable PF support'
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-03 12:53 UTC by Nikola Kolev
Modified: 2018-07-04 14:22 UTC (History)
1 user (show)

See Also:
koue: maintainer-feedback+


Attachments
dhcpd nopf patch (4.95 KB, text/plain)
2018-07-03 12:53 UTC, Nikola Kolev
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikola Kolev 2018-07-03 12:53:53 UTC
Created attachment 194856 [details]
dhcpd nopf patch

Current net/dhcpd port has no options defined. There is request to be able to compile the port if PF is not part of the base system.
Comment 1 Steve Wills freebsd_committer 2018-07-03 20:03:29 UTC
(In reply to Nikola Kolev from comment #0)

Why does this patch remove the USERS and GROUPS lines? Is that somehow required to build without pf support?
Comment 2 Dries Michiels 2018-07-04 09:03:40 UTC
As far as I recall, only isc-dhcpd uses the dhcpd user.
dhcpd from OpenBSD uses the base system _dhcp user as seen below:
_dhcp        16854   0.0  0.0    8916   5196  -  Is   14Jun18      0:05.53 /usr/local/sbin/dhcpd igb0

Unless there is a specific reason to keep the dhcpd user installed? 
It isn't used anywhere for net/dhcpd.
Comment 3 Nikola Kolev 2018-07-04 09:33:07 UTC
Adding USERS and GROUPS was mistake while creating the port. The daemon is using the default "_dhcp" user.

src/usr.sbin/dhcpd/dhcpd.c:	if ((pw = getpwnam("_dhcp")) == NULL)

Removing them from the Makefile is simply clean up.

Thanks to Dries for pointing this out.
Comment 4 commit-hook freebsd_committer 2018-07-04 14:21:43 UTC
A commit references this bug:

Author: swills
Date: Wed Jul  4 14:21:08 UTC 2018
New revision: 473889
URL: https://svnweb.freebsd.org/changeset/ports/473889

Log:
  net/dhcpd: Add option to disable PF support

  While here, remove unneeded USERS and GROUPS lines.

  PR:		229490
  Submitted by:	Nikola Kolev <koue@chaosophia.net> (maintainer)

Changes:
  head/net/dhcpd/Makefile
  head/net/dhcpd/files/extra-patch-dhcp.c
  head/net/dhcpd/files/extra-patch-dhcpd.c
  head/net/dhcpd/files/extra-patch-memory.c
  head/net/dhcpd/files/extra-patch-pfutils.c
Comment 5 Steve Wills freebsd_committer 2018-07-04 14:22:15 UTC
Committed, thanks!