Bug 229521 - devel/llvm*: enable OPENMP on i386
Summary: devel/llvm*: enable OPENMP on i386
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: feature, patch, patch-ready
Depends on:
Blocks: 210337
  Show dependency treegraph
 
Reported: 2018-07-05 00:09 UTC by Jan Beich
Modified: 2019-03-16 21:13 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (brooks)


Attachments
v1 (9.36 KB, patch)
2018-07-05 00:09 UTC, Jan Beich
brooks: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2018-07-05 00:09:34 UTC
Created attachment 194882 [details]
v1

ports r447281 added i386 support to devel/openmp. Let's copy that.
Comment 1 Jan Beich freebsd_committer 2018-07-05 01:53:56 UTC
Build logs from 11.1 i386:
llvm38     - https://ptpb.pw/1Co4
llvm40     - https://ptpb.pw/iA2L
llvm50     - https://ptpb.pw/UdZL
llvm60     - https://ptpb.pw/VLei
llvm-devel - https://ptpb.pw/gPtg
Comment 2 Jan Beich freebsd_committer 2018-07-05 01:57:48 UTC
Runtime testing on 11.1 i386:
$ pkg install ca_root_nss llvm38
$ fetch https://computing.llnl.gov/tutorials/openMP/samples/C/omp_hello.c
$ clang38 -fopenmp omp_hello.c
$ ./a.out
Hello World from thread = 0
Hello World from thread = 1
Hello World from thread = 2
Hello World from thread = 3
Number of threads = 8
Hello World from thread = 4
Hello World from thread = 5
Hello World from thread = 6
Hello World from thread = 7
Comment 3 Brooks Davis freebsd_committer 2018-07-05 08:47:33 UTC
Comment on attachment 194882 [details]
v1

Looks good to me.
Comment 4 commit-hook freebsd_committer 2018-07-05 09:03:53 UTC
A commit references this bug:

Author: jbeich
Date: Thu Jul  5 09:02:54 UTC 2018
New revision: 473956
URL: https://svnweb.freebsd.org/changeset/ports/473956

Log:
  devel/llvm*: apply r447281 and enable OPENMP on i386

  PR:		229521
  Approved by:	brooks (maintainer)
  MFH:		2018Q3

Changes:
  head/devel/llvm-devel/Makefile
  head/devel/llvm-devel/files/openmp/patch-i386
  head/devel/llvm38/Makefile
  head/devel/llvm38/files/openmp-patch-i386
  head/devel/llvm40/Makefile
  head/devel/llvm40/files/openmp-patch-i386
  head/devel/llvm50/Makefile
  head/devel/llvm50/files/openmp-patch-i386
  head/devel/llvm60/Makefile
  head/devel/llvm60/files/openmp/patch-i386
Comment 5 commit-hook freebsd_committer 2018-07-05 18:52:53 UTC
A commit references this bug:

Author: jbeich
Date: Thu Jul  5 18:52:21 UTC 2018
New revision: 473980
URL: https://svnweb.freebsd.org/changeset/ports/473980

Log:
  MFH: r473956

  devel/llvm*: apply r447281 and enable OPENMP on i386

  PR:		229521
  Approved by:	brooks (maintainer)
  Approved by:	ports-secteam (miwi)

Changes:
_U  branches/2018Q3/
  branches/2018Q3/devel/llvm-devel/Makefile
  branches/2018Q3/devel/llvm-devel/files/openmp/patch-i386
  branches/2018Q3/devel/llvm38/Makefile
  branches/2018Q3/devel/llvm38/files/openmp-patch-i386
  branches/2018Q3/devel/llvm40/Makefile
  branches/2018Q3/devel/llvm40/files/openmp-patch-i386
  branches/2018Q3/devel/llvm50/Makefile
  branches/2018Q3/devel/llvm50/files/openmp-patch-i386
  branches/2018Q3/devel/llvm60/Makefile
  branches/2018Q3/devel/llvm60/files/openmp/patch-i386