Bug 229539 - [PATCH] FDP Primer: Chapter 12. PO Translations: 'TRANSLATOR' is already set for 'textproc/docproj'
Summary: [PATCH] FDP Primer: Chapter 12. PO Translations: 'TRANSLATOR' is already set ...
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Books & Articles (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Guangyuan Yang
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2018-07-05 12:40 UTC by Vinícius Zavam
Modified: 2018-12-25 12:26 UTC (History)
5 users (show)

See Also:

Attachments
[PATCH] FDP Primer: Chapter 12. PO Translations: 'TRANSLATOR' is already set for 'textproc/docproj' (1.15 KB, patch)
2018-07-05 12:40 UTC, Vinícius Zavam 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vinícius Zavam freebsd_committer freebsd_triage 2018-07-05 12:40:00 UTC 
Created attachment 194897 [details]
[PATCH] FDP Primer: Chapter 12. PO Translations: 'TRANSLATOR' is already set for 'textproc/docproj'

en_US.ISO8859-1/books/fdp-primer/po-translations/chapter.xml;

this chapter pointed that the 'TRANSLATOR' option should be set for textproc/docproj, but I see it is already enabled by default. patch available.
Comment 1 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-07-20 13:40:30 UTC 
Maybe we could reword it so that it says that "the TRANSLATOR option is required and also enabled by default in the port".
Comment 2 Vinícius Zavam freebsd_committer freebsd_triage 2018-07-24 11:37:02 UTC 
(In reply to Mateusz Piotrowski from comment #1)

Hi Mateusz, thanks for having a look into it. very appreciated! I just have 2 questions: 1) isn't this kind of information present on the port itself? 2) why add extra info?

I mean:

  a) the option is already enabled by default;
  b) one does not need to bother building anything;
  c) the package can be installed via pkg (with the TRANSLATOR option enabled);
  d) if someone *really* wants to disable it, can use the 'make config' step.

IMHO, I'd just vote for removing the text.
Comment 3 Vinícius Zavam freebsd_committer freebsd_triage 2018-11-28 10:01:47 UTC 
adding mentors in CC.
Comment 4 Rene Ladan freebsd_committer freebsd_triage 2018-11-28 10:06:57 UTC 
Hmmm, this is a doc and not a ports PR...
Comment 5 Vinícius Zavam freebsd_committer freebsd_triage 2018-11-28 13:57:01 UTC 
does any timeout applies?
Comment 6 Guangyuan Yang freebsd_committer freebsd_triage 2018-11-29 00:29:46 UTC 
I vote for just removing it.
Comment 7 Vinícius Zavam freebsd_committer freebsd_triage 2018-12-24 16:06:53 UTC 
(In reply to Guangyuan Yang from comment #6)

hey ygy@, thanks for taking this one. very appreciated!
Comment 8 commit-hook freebsd_committer freebsd_triage 2018-12-25 06:06:26 UTC 
A commit references this bug:

Author: ygy
Date: Tue Dec 25 06:05:26 UTC 2018
New revision: 52724
URL: https://svnweb.freebsd.org/changeset/doc/52724

Log:
  TRANSLATOR option is currently enabled by default in textproc/docproj. Reword instructions to reflect this in PO Translation Quick Start.

  PR:		229539
  Reported by:	egypcio

Changes:
  head/en_US.ISO8859-1/books/fdp-primer/po-translations/chapter.xml