Bug 229697 - databases/foundationdb: fails to build with boost 1.68
Summary: databases/foundationdb: fails to build with boost 1.68
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Vanilla I. Shu
URL:
Keywords: needs-patch
Depends on:
Blocks: 229569
  Show dependency treegraph
 
Reported: 2018-07-11 13:08 UTC by Jan Beich
Modified: 2018-08-14 15:00 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (vanilla)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2018-07-11 13:08:26 UTC
After bug 229569 lands this port will end up BROKEN. Can you help? I've already reported upstream.

In file included from flow/boost.cpp:21:
flow/libs/system/src/error_code.cpp:417:46: error: redefinition of 'system_category'
    BOOST_SYSTEM_DECL const error_category & system_category() BOOST_SYSTEM_NOEXCEPT
                                             ^
/usr/local/include/boost/system/error_code.hpp:480:31: note: previous definition is here
inline const error_category & system_category() BOOST_SYSTEM_NOEXCEPT
                              ^
In file included from flow/boost.cpp:21:
flow/libs/system/src/error_code.cpp:423:46: error: redefinition of 'generic_category'
    BOOST_SYSTEM_DECL const error_category & generic_category() BOOST_SYSTEM_NOEXCEPT
                                             ^
/usr/local/include/boost/system/error_code.hpp:485:31: note: previous definition is here
inline const error_category & generic_category() BOOST_SYSTEM_NOEXCEPT
                              ^
2 errors generated.
Comment 1 Walter Schwarzenfeld freebsd_triage 2018-07-11 14:27:08 UTC
simple 

#undef BOOST_SYSTEM_NOEXCEPT
in flow/libs/system/src/error_code.cpp ??
Comment 2 Vanilla I. Shu freebsd_committer 2018-07-17 13:14:34 UTC
Hi jbeich@

any way to download whole boost related patches?
Comment 3 Jan Beich freebsd_committer 2018-07-17 16:07:31 UTC
Try the following:

$ fetch -qo- 'https://reviews.freebsd.org/D16165?download=true' | patch -Efsp0 -d /usr/ports
$ make all deinstall install clean -C/usr/ports/devel/boost-jam
$ make all deinstall install clean -C/usr/ports/devel/boost-libs
$ make -C /usr/ports/databases/foundationdb
Comment 4 Jan Beich freebsd_committer 2018-08-09 07:00:55 UTC
Marked BROKEN in ports r476723.
Comment 5 commit-hook freebsd_committer 2018-08-14 15:00:11 UTC
A commit references this bug:

Author: vanilla
Date: Tue Aug 14 14:59:52 UTC 2018
New revision: 477160
URL: https://svnweb.freebsd.org/changeset/ports/477160

Log:
  Update to 5.2.8, and fix building with boost 1.68.

  PR:		229697

Changes:
  head/databases/foundationdb/Makefile
  head/databases/foundationdb/distinfo
  head/databases/foundationdb/files/patch-Makefile
  head/databases/foundationdb/files/patch-build_csprojtom4.py
  head/databases/foundationdb/files/patch-build_vcxprojtom4.py
  head/databases/foundationdb/files/patch-fdbbackup_local.mk
  head/databases/foundationdb/files/patch-fdbcli_local.mk
  head/databases/foundationdb/files/patch-fdbclient_local.mk
  head/databases/foundationdb/files/patch-fdbmonitor_fdbmonitor.cpp
  head/databases/foundationdb/files/patch-fdbrpc_IAsyncFile.actor.cpp
  head/databases/foundationdb/files/patch-fdbrpc_Platform.cpp
  head/databases/foundationdb/files/patch-fdbrpc_local.mk
  head/databases/foundationdb/files/patch-fdbserver_fdbserver.actor.cpp
  head/databases/foundationdb/files/patch-fdbserver_local.mk
  head/databases/foundationdb/files/patch-fdbserver_worker.actor.cpp
  head/databases/foundationdb/files/patch-flow_Deque.h
  head/databases/foundationdb/files/patch-flow_Net2.actor.cpp
  head/databases/foundationdb/files/patch-flow_Platform.cpp
  head/databases/foundationdb/files/patch-flow_Platform.h
  head/databases/foundationdb/files/patch-flow_ThreadPrimitives.cpp
  head/databases/foundationdb/files/patch-flow_ThreadPrimitives.h
  head/databases/foundationdb/files/patch-flow_libs_system_src_error__code.cpp
  head/databases/foundationdb/files/patch-flow_local.mk
Comment 6 Vanilla I. Shu freebsd_committer 2018-08-14 15:00:58 UTC
I make a patch to fix building with boost 1.68, and it works.