src/lib/libefivar/efivar-dp-parse.c:344]: (style) Redundant condition: If 'EXPR == ' '', the comparison 'EXPR != 0' is always true. [src/lib/libefivar/efivar-dp-parse.c:350]: (style) Redundant condition: If 'EXPR == '0'', the comparison 'EXPR != 0' is always true. Source code is while ((*Str != 0) && *Str == ' ') { Str ++; } // // skip preceeding zeros // while ((*Str != 0) && *Str == '0') { maybe better code while (*Str == ' ') { Str ++; } // // skip preceeding zeros // while (*Str == '0') {
This codes comes from EDK2, with as few local modifications as possible. We don't change this code unless there's a really really good reason so we can import again from EDK2 when the time comes. Not sure what this warning comes from, but if it's the compiler, you should disable that warning for this code. We won't be changing it until the next upstream import, even if this is 100% a fair assessment of the code.