Bug 229729 - graphics/mozjpeg: remove BROKEN_aarch64
Summary: graphics/mozjpeg: remove BROKEN_aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm64 Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks: 201763
  Show dependency treegraph
 
Reported: 2018-07-12 12:37 UTC by Greg V
Modified: 2018-07-18 03:17 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
mozjpeg.patch (546 bytes, patch)
2018-07-12 12:37 UTC, Greg V
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg V 2018-07-12 12:37:48 UTC
Created attachment 195080 [details]
mozjpeg.patch

https://github.com/freebsd/freebsd-ports/commit/d19ffea93fa7a60f89d0870efae87169f351b42d

ARMv8 NEON SIMD has been available since v3.0-pre: https://github.com/mozilla/mozjpeg/commit/1bb1e691865a3534327c26f91fda0f0bf05a3a51

I guess a couple years ago there was a problem with our assembler maybe?

Builds and works fine now.

(BTW, this port can be unbroken on mips64 and sparc64 by disabling the SIMD option, but it would be nice if someone with the hardware actually tested it.)
Comment 1 Jan Beich freebsd_committer 2018-07-18 03:14:06 UTC
BROKEN_aarch64 was added by linimon@ in ports r426197 based on
https://lists.freebsd.org/pipermail/freebsd-pkg-fallout/Week-of-Mon-20161107/351005.html
Comment 2 commit-hook freebsd_committer 2018-07-18 03:15:00 UTC
A commit references this bug:

Author: jbeich
Date: Wed Jul 18 03:14:51 UTC 2018
New revision: 474832
URL: https://svnweb.freebsd.org/changeset/ports/474832

Log:
  graphics/mozjpeg: drop BROKEN_aarch64

  PR:		229729
  Submitted by:	Greg V

Changes:
  head/graphics/mozjpeg/Makefile
Comment 3 commit-hook freebsd_committer 2018-07-18 03:16:03 UTC
A commit references this bug:

Author: jbeich
Date: Wed Jul 18 03:15:30 UTC 2018
New revision: 474833
URL: https://svnweb.freebsd.org/changeset/ports/474833

Log:
  MFH: r474832

  graphics/mozjpeg: drop BROKEN_aarch64

  PR:		229729
  Submitted by:	Greg V
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2018Q3/
  branches/2018Q3/graphics/mozjpeg/Makefile
Comment 4 Jan Beich freebsd_committer 2018-07-18 03:17:50 UTC
Thanks. Landed. I confirm it builds fine on 11.1/12.0 aarch64 (via qemu-user).