Bug 229817 - sysutils/py-google-compute-engine: GCE instances can't run startup scripts due to bash set as default shell instead of sh
Summary: sysutils/py-google-compute-engine: GCE instances can't run startup scripts du...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Steve Wills
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2018-07-17 01:37 UTC by gustavo.scalet
Modified: 2018-07-18 16:36 UTC (History)
2 users (show)

See Also:
helen.koike: maintainer-feedback+
swills: merge-quarterly+

Attachments
patch to FreeBSD's ports (1.23 KB, patch)
2018-07-17 01:37 UTC, gustavo.scalet 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description gustavo.scalet 2018-07-17 01:37:59 UTC 
Created attachment 195184 [details]
patch to FreeBSD's ports

To use FreeBSD in the Google Cloud Engine, you need the agent provided by the package py27-google-compute-engine installed. That package has wrongly set the default shell as bash and the minimum image of FreeBSD doesn't have it installed so python commands fail when executing subprocess.Popen calls as it requests a shell that doesn't exist.

The simple fix in attachment solves the issue by replacing the default shell to be /bin/sh
Comment 1 Helen Koike 2018-07-17 09:37:19 UTC 
Comment on attachment 195184 [details]
patch to FreeBSD's ports

Thanks for the patch!
Comment 2 Helen Koike 2018-07-17 09:37:21 UTC 
Comment on attachment 195184 [details]
patch to FreeBSD's ports

Thanks for the patch!
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-07-18 14:29:04 UTC 
A commit references this bug:

Author: swills
Date: Wed Jul 18 14:28:04 UTC 2018
New revision: 474866
URL: https://svnweb.freebsd.org/changeset/ports/474866

Log:
  sysutils/py-google-compute-engine: fix default shell

  PR:		229817
  Submitted by:	Gustavo Serra Scalet <gustavo.scalet@collabora.com>
  Approved by:	Helen Koike <helen.koike@collabora.com> (maintainer)
  MFH:		2018Q3

Changes:
  head/sysutils/py-google-compute-engine/Makefile
  head/sysutils/py-google-compute-engine/files/instance_configs.cfg.distro.sample
Comment 4 Steve Wills freebsd_committer freebsd_triage 2018-07-18 14:30:47 UTC 
Committed, thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-07-18 16:36:10 UTC 
A commit references this bug:

Author: swills
Date: Wed Jul 18 16:35:31 UTC 2018
New revision: 474882
URL: https://svnweb.freebsd.org/changeset/ports/474882

Log:
  MFH: r474866

  sysutils/py-google-compute-engine: fix default shell

  PR:		229817
  Submitted by:	Gustavo Serra Scalet <gustavo.scalet@collabora.com>
  Approved by:	Helen Koike <helen.koike@collabora.com> (maintainer)
  Approved by:	ports-secteam (implicit)

Changes:
_U  branches/2018Q3/
  branches/2018Q3/sysutils/py-google-compute-engine/Makefile
  branches/2018Q3/sysutils/py-google-compute-engine/files/instance_configs.cfg.distro.sample