Bug 229845 - emulators/virtualbox-ose-additions: macro from sys/priority.h conflicts with typedef in VirtualBox-5.2.14/include/VBox/types.h on base/head r336361
Summary: emulators/virtualbox-ose-additions: macro from sys/priority.h conflicts with ...
Status: Closed DUPLICATE of bug 229561
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Virtualbox Team (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-17 20:03 UTC by Trond Endrestøl
Modified: 2018-07-17 22:15 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (vbox)

Attachments
Patch for VirtualBox-5.2.14/include/VBox/types.h (372 bytes, text/plain)
2018-07-17 20:03 UTC, Trond Endrestøl 		no flags Details
Complete build log from synth (539.16 KB, text/plain)
2018-07-17 20:05 UTC, Trond Endrestøl 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Trond Endrestøl 2018-07-17 20:03:56 UTC 
Created attachment 195212 [details]
Patch for VirtualBox-5.2.14/include/VBox/types.h

Here's an extract from synth's build log.

In file included from /construction/xports/emulators/virtualbox-ose-additions/work/VirtualBox-5.2.14/src/VBox/Additions/common/VBoxGuest/lib/VBoxGuestR0LibCrOgl.cpp:32:
In file included from /construction/xports/emulators/virtualbox-ose-additions/work/VirtualBox-5.2.14/src/VBox/Additions/common/VBoxGuest/lib/VBoxGuestR0LibInternal.h:59:
In file included from /construction/xports/emulators/virtualbox-ose-additions/work/VirtualBox-5.2.14/include/VBox/VMMDev.h:31:
/construction/xports/emulators/virtualbox-ose-additions/work/VirtualBox-5.2.14/include/VBox/types.h:78:37: error: expected unqualified-id
typedef struct VM                  *PVM;
                                    ^
/usr/src/sys/sys/priority.h:104:16: note: expanded from macro 'PVM'
#define PVM                     (PRI_MIN_KERN + 4)
                                 ^
/usr/src/sys/sys/priority.h:100:24: note: expanded from macro 'PRI_MIN_KERN'
#define PRI_MIN_KERN            (80)
                                 ^
In file included from /construction/xports/emulators/virtualbox-ose-additions/work/VirtualBox-5.2.14/src/VBox/Additions/common/VBoxGuest/lib/VBoxGuestR0LibCrOgl.cpp:32:
In file included from /construction/xports/emulators/virtualbox-ose-additions/work/VirtualBox-5.2.14/src/VBox/Additions/common/VBoxGuest/lib/VBoxGuestR0LibInternal.h:59:
In file included from /construction/xports/emulators/virtualbox-ose-additions/work/VirtualBox-5.2.14/include/VBox/VMMDev.h:31:
/construction/xports/emulators/virtualbox-ose-additions/work/VirtualBox-5.2.14/include/VBox/types.h:78:37: error: expected ')'
/usr/src/sys/sys/priority.h:104:16: note: expanded from macro 'PVM'
#define PVM                     (PRI_MIN_KERN + 4)
                                 ^
/usr/src/sys/sys/priority.h:100:24: note: expanded from macro 'PRI_MIN_KERN'
#define PRI_MIN_KERN            (80)
                                 ^
/construction/xports/emulators/virtualbox-ose-additions/work/VirtualBox-5.2.14/include/VBox/types.h:78:37: note: to match this '('
/usr/src/sys/sys/priority.h:104:16: note: expanded from macro 'PVM'
#define PVM                     (PRI_MIN_KERN + 4)
                                 ^
/usr/src/sys/sys/priority.h:100:23: note: expanded from macro 'PRI_MIN_KERN'
#define PRI_MIN_KERN            (80)
                                ^

See attached patch for a possible solution.
Comment 1 Trond Endrestøl 2018-07-17 20:05:02 UTC 
Created attachment 195213 [details]
Complete build log from synth
Comment 2 Trond Endrestøl 2018-07-17 20:31:19 UTC 
I do realise the build log is from a previous run when this VM ran r335932. synth is currently churning away on r336361, and I expect a positive result in about 110 ports or so.
Comment 3 Jung-uk Kim freebsd_committer freebsd_triage 2018-07-17 22:15:18 UTC 
It should be fixed in r474458.

https://svnweb.freebsd.org/changeset/ports/474458

Also, it was MFH'd to 2018Q3 in r474461.

https://svnweb.freebsd.org/changeset/ports/474461

*** This bug has been marked as a duplicate of bug 229561 ***