Bug 229856 - graphics/zathura: Requires gettext-tools with NLS option off
Summary: graphics/zathura: Requires gettext-tools with NLS option off
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexandre C. Guimarães
URL: https://reviews.freebsd.org/D19301
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2018-07-18 08:22 UTC by João Neves
Modified: 2019-02-24 00:45 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (quentin.stievenart)

Attachments
zathura build log (synth) (31.91 KB, text/plain)
2018-07-18 08:22 UTC, João Neves 		no flags Details
Fixes bug (3.56 KB, patch)
2018-08-25 20:26 UTC, Nathan 		no flags Details | Diff
Fix missing gettext (3.52 KB, patch)
2018-09-10 04:32 UTC, Nathan 		ndowens04: maintainer-approval? (quentin.stievenart)
 Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description João Neves 2018-07-18 08:22:40 UTC 
Created attachment 195233 [details]
zathura build log (synth)

Hi,

Since the latest port update, zathura fails to configure when the NLS option is off due to lack of xgettext, installed by devel/gettext-tools.

I'm building with Synth on FreeBSD 11.2-RELEASE amd64. I've attached the build log (I don't seem to be able to get to the meson log when building through Synth, but the error should be clear enough in this log file).

Cheers,
Comment 1 Nathan 2018-08-23 16:43:23 UTC 
Testing this myself. If I can reproduce it , I’ll introduce a patch
Comment 2 Nathan 2018-08-23 19:54:28 UTC 
(In reply to Nathan from comment #1)
Update. I get it as well. I have update ready but can’t upload it on phone and gonna look at more on pc
Comment 3 Nathan 2018-08-25 20:26:13 UTC 
Created attachment 196544 [details]
Fixes bug


graphics/zathura:

* Removed NLS option
 -- Does not exist in meson.build nor meson_options
* Added gettext to USES
 -- Fixes bug# 229856
Comment 4 Nathan 2018-08-26 22:11:28 UTC 
maintainer timeout (quentin.stievenart@gmail.com ; 39 days)
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2018-08-27 07:36:41 UTC 
@Nathan

1) Timeouts occur (are measured) on patches/attachments (not issue report date/time)

2) NLS removal: "Does not exist in meson.build nor meson_options" contradicts the provided build log, which shows:

"po/meson.build:2:5: ERROR:  Can not do gettext because xgettext is not installed."

3) Why *gettext* anything is required with NLS off/disables should be explained in any
Comment 6 Nathan 2018-08-27 16:03:18 UTC 
(In reply to Kubilay Kocak from comment #5)
Gettext IIRC is listed as an dep but I didn’t see any enable/disable nls
Comment 7 Nathan 2018-08-27 16:30:07 UTC 
(In reply to Kubilay Kocak from comment #5)
@koobs how are you getting that error. Mine builds fine
Comment 8 Nathan 2018-08-28 03:34:35 UTC 
looks more like that had issue with glib really than gettext, as this builds fine with 12 and 11
Comment 9 Nathan 2018-09-10 04:32:57 UTC 
Created attachment 196998 [details]
Fix missing gettext

Removed NLS option and added gettext to uses as no way to turn off nls and the dependency of gettext
Comment 10 Philipp Engel 2018-10-18 10:22:28 UTC 
When will the patch be committed?