Bug 229946 - devel/py-pip: Update to 19.1.1
Summary: devel/py-pip: Update to 19.1.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on: 238792 238793
Blocks:
  Show dependency treegraph
 
Reported: 2018-07-22 05:35 UTC by Nathan
Modified: 2019-06-30 21:29 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (python)


Attachments
Patch to update (1.61 KB, patch)
2018-07-22 05:35 UTC, Nathan
no flags Details | Diff
Update (2.00 KB, patch)
2018-08-16 04:24 UTC, Nathan
no flags Details | Diff
Update to 18.1 (2.56 KB, text/plain)
2018-11-13 02:51 UTC, wen
no flags Details
Update (2.73 KB, patch)
2018-11-13 05:23 UTC, Nathan
no flags Details | Diff
patch to update pip to 19.1.1 (3.14 KB, patch)
2019-06-03 14:13 UTC, Steve Wills
no flags Details | Diff
updated patch to update pip to 19.1.1 (3.14 KB, patch)
2019-06-03 14:23 UTC, Steve Wills
no flags Details | Diff
updated patch (6.04 KB, patch)
2019-06-18 17:37 UTC, Steve Wills
no flags Details | Diff
Updated patch (6.01 KB, patch)
2019-06-20 12:41 UTC, Steve Wills
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan 2018-07-22 05:35:06 UTC
Created attachment 195358 [details]
Patch to update

Builds fine on 10.4-R and 11.2-Stable

Features/Fixes from previous version to this version:
https://pastebin.com/MkvmVzh2
Comment 1 Nathan 2018-08-16 04:24:57 UTC
Created attachment 196245 [details]
Update
Comment 2 wen 2018-11-13 02:47:34 UTC
Seems the doc build failed.

wen
Comment 3 Nathan 2018-11-13 02:49:50 UTC
(In reply to wen from comment #2)
Will re-look at, ASAP, and probably will update version, as there is possibly a newer version by now
Comment 4 wen 2018-11-13 02:51:51 UTC
Created attachment 199192 [details]
Update to 18.1

The new patch:

- Update to 18.1
- Change MASTER_SITES to CHEESESHOP
- Comment out doc build temporarily
Comment 5 Nathan 2018-11-13 05:23:49 UTC
Created attachment 199193 [details]
Update

Built fine on 12 AMD64
Comment 6 Nathan 2018-11-13 05:24:30 UTC
Comment on attachment 199193 [details]
Update

Removing, after seeing wen's patch
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2019-04-29 05:32:25 UTC
pip 19.1 is out, pending updated patch

Would be great to get QA re-confirmation (including `make test`) before we submit it exp-run

Assignee timeout (9 months, reset to python@)
Comment 8 Steve Wills freebsd_committer freebsd_triage 2019-06-03 14:13:04 UTC
Created attachment 204807 [details]
patch to update pip to 19.1.1

Perhaps this will work?
Comment 9 Steve Wills freebsd_committer freebsd_triage 2019-06-03 14:23:43 UTC
Created attachment 204808 [details]
updated patch to update pip to 19.1.1

Slight improvement to the patch
Comment 10 Steve Wills freebsd_committer freebsd_triage 2019-06-18 02:38:08 UTC
(In reply to Kubilay Kocak from comment #7)
Previous updates to this haven't required an exp-run and I don't think this one should either. What makes you think it should?
Comment 11 Kubilay Kocak freebsd_committer freebsd_triage 2019-06-18 02:41:54 UTC
(In reply to Steve Wills from comment #10)

I overstated it in comment 7. I should have said may be worth an exp-run

That would be up to the person working on it and contingent on size, complexity, degree of updates (and upstream changes), and QA results
Comment 12 Steve Wills freebsd_committer freebsd_triage 2019-06-18 17:37:15 UTC
Created attachment 205208 [details]
updated patch

This seems better and passes all but 3 tests, only one of which seems possibly legitimate, so I think it's fine for now.
Comment 13 Steve Wills freebsd_committer freebsd_triage 2019-06-19 17:17:51 UTC
(In reply to Steve Wills from comment #12)
Turns out those 3 test failures are all buggy tests, so it's fine. Can I get python@ approval?
Comment 14 wen 2019-06-19 23:07:54 UTC
(In reply to Steve Wills from comment #13)
I can not fetch setuptools-41.0.1-py2.py3-none-any.whl here.

wen
Comment 15 Steve Wills freebsd_committer freebsd_triage 2019-06-20 02:37:53 UTC
(In reply to wen from comment #14)
Can you please tell me the error message?
Comment 16 wen 2019-06-20 02:50:00 UTC
# make makesum

.....

===>  License MIT accepted by the user
=> setuptools-41.0.1-py2.py3-none-any.whl doesn't seem to exist in /usr/ports/distfiles/pip.
=> Attempting to fetch https://pypi.org/packages/setuptools-41.0.1-py2.py3-none-any.whl
fetch: https://pypi.org/packages/setuptools-41.0.1-py2.py3-none-any.whl: Not Found
=> Attempting to fetch http://distcache.FreeBSD.org/ports-distfiles/pip/setuptools-41.0.1-py2.py3-none-any.whl
fetch: http://distcache.FreeBSD.org/ports-distfiles/pip/setuptools-41.0.1-py2.py3-none-any.whl: Not Found
=> Couldn't fetch it - please try to retrieve this
=> port manually into /usr/ports/distfiles/pip and try again.
*** Error code 1
(In reply to Steve Wills from comment #15)
Comment 17 Steve Wills freebsd_committer freebsd_triage 2019-06-20 12:41:18 UTC
Created attachment 205234 [details]
Updated patch

This should fix the test file patch, sorry, I let portlint lead me astray and failed to re-verify the download.
Comment 18 Martin Wilke freebsd_committer freebsd_triage 2019-06-24 14:11:44 UTC
Hi Steve,

thanks for the update, last time i check we had some fallouts, i'd suggest to request an exp-run.
Comment 19 commit-hook freebsd_committer freebsd_triage 2019-06-29 13:00:48 UTC
A commit references this bug:

Author: swills
Date: Sat Jun 29 12:59:56 UTC 2019
New revision: 505348
URL: https://svnweb.freebsd.org/changeset/ports/505348

Log:
  devel/py-pip: Update to 19.1.1

  PR:		229946
  Reviewed by:	wen, miwi, koobs
  Approved by:	miwi

Changes:
  head/devel/py-pip/Makefile
  head/devel/py-pip/distinfo
  head/devel/py-pip/files/patch-setup.cfg
  head/devel/py-pip/files/patch-setup.py