Bug 230001 - net/sniproxy: multiple issues
Summary: net/sniproxy: multiple issues
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kirill Ponomarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-24 02:52 UTC by david
Modified: 2018-07-24 14:50 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (krion)

Attachments
Patch for rc startup script (379 bytes, patch)
2018-07-24 02:52 UTC, david 		no flags Details | Diff
patch for accept4 issue (474 bytes, patch)
2018-07-24 02:53 UTC, david 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description david 2018-07-24 02:52:49 UTC 
Created attachment 195409 [details]
Patch for rc startup script

The startup script has a missing ' "} ' on line 25, additionally the 'accept4()' implementation is different between FreeBSD and linux, with FreeBSD using SOCK_NONBLOCK instead of O_NONBLOCK for the flags parameter of accept4
Comment 1 david 2018-07-24 02:53:24 UTC 
Created attachment 195410 [details]
patch for accept4 issue
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-07-24 14:50:51 UTC 
A commit references this bug:

Author: krion
Date: Tue Jul 24 14:50:34 UTC 2018
New revision: 475258
URL: https://svnweb.freebsd.org/changeset/ports/475258

Log:
  Utilize SOCK_NONBLOCK instead of O_NONBLOCK
  Fix startup script

  PR:		230001
  Submitted by:	david@dcrosstech.com

Changes:
  head/net/sniproxy/Makefile
  head/net/sniproxy/files/patch-src_connection.c
  head/net/sniproxy/files/sniproxy.in