Bug 230048 - Document existence of new ipfw queue types
Summary: Document existence of new ipfw queue types
Status: Closed Overcome By Events
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guangyuan Yang
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-07-26 03:22 UTC by Kevin Zheng
Modified: 2018-12-01 06:05 UTC (History)
4 users (show)

See Also:


Attachments
Patch (572 bytes, patch)
2018-07-26 03:22 UTC, Kevin Zheng
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Zheng 2018-07-26 03:22:17 UTC
Created attachment 195462 [details]
Patch

Available queue types in dummynet are here:
/usr/src/sys/netpfil/ipfw/dn_sched_*

The ipfw man page documents some of them, but the newer ones are undocumented. The attached patch enumerates the new options, but does not attempt to document what they do. Arguably, this is better than not documenting them at all.
Comment 1 Rasool Al-Saadi 2018-08-02 23:41:04 UTC
Thank you Kevin for creating the patch.

There is already a patch on FreeBSD's Phabricator (still under review) for ipfw man page that documents Dummynet's new AQMs (CoDel and PIE) and hybrid schedulers/AQMs (FQ-CoDel and FQ-PIE). The patch includes descriptions, configurations, sysctl and examples for Dummynet's new AQMs/schedulers. You can find the patch at https://reviews.freebsd.org/D12507
Comment 2 Kevin Zheng 2018-08-03 18:02:27 UTC
(In reply to Rasool Al-Saadi from comment #1)
Thanks for the update. I think this patch is still relevant because it mentions the existence of the prio scheduler, whatever that does.

I think this should be kept open until the Phabricator review goes through?
Comment 3 Rasool Al-Saadi 2018-11-29 01:13:20 UTC
Documentation of Dummynet's new AQMs (CoDel and PIE) and hybrid schedulers/AQMs (FQ-CoDel and FQ-PIE) has been added to FreeBSD+12-current ipfw man page.
I think this bug has been solved and should be closed now.
Cheers
Comment 4 Kevin Zheng 2018-11-29 06:28:31 UTC
Great, thanks.
Comment 5 Guangyuan Yang freebsd_committer freebsd_triage 2018-12-01 06:05:26 UTC
Committed as r338977.