Bug 230052 - [PATCH] sysutils/openipmi: update to 2.0.25
Summary: [PATCH] sysutils/openipmi: update to 2.0.25
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Renato Botelho
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-07-26 09:20 UTC by Vinícius Zavam
Modified: 2018-08-24 12:46 UTC (History)
1 user (show)

See Also:


Attachments
[PATCH] sysutils/openipmi: update to 2.0.25 (18.76 KB, patch)
2018-07-26 09:20 UTC, Vinícius Zavam
no flags Details | Diff
[LOG/10amd64] sysutils/openipmi: update to 2.0.25 (172.16 KB, text/plain)
2018-07-26 09:23 UTC, Vinícius Zavam
no flags Details
[LOG/11amd64] sysutils/openipmi: update to 2.0.25 (171.20 KB, text/plain)
2018-07-26 09:23 UTC, Vinícius Zavam
no flags Details
[LOG/10amd64] sysutils/openipmi: update to 2.0.25, ALL OPTIONS (238.27 KB, text/plain)
2018-07-26 09:33 UTC, Vinícius Zavam
no flags Details
[LOG/11amd64] sysutils/openipmi: update to 2.0.25, ALL OPTIONS (243.79 KB, text/plain)
2018-07-26 09:33 UTC, Vinícius Zavam
no flags Details
[PATCH] sysutils/openipmi: update to 2.0.25 (21.31 KB, patch)
2018-07-30 14:48 UTC, Vinícius Zavam
no flags Details | Diff
[LOG/11amd64] sysutils/openipmi: update to 2.0.25 (169.37 KB, text/plain)
2018-07-30 14:49 UTC, Vinícius Zavam
no flags Details
[LOG/10amd64] sysutils/openipmi: update to 2.0.25 (170.33 KB, text/plain)
2018-07-30 14:52 UTC, Vinícius Zavam
no flags Details
[LOG/11amd64] sysutils/openipmi: update to 2.0.25, ALL OPTIONS GLIB12 (233.08 KB, text/plain)
2018-07-30 14:53 UTC, Vinícius Zavam
no flags Details
[LOG/11amd64] sysutils/openipmi: update to 2.0.25, ALL OPTIONS GLIB20 (241.98 KB, text/plain)
2018-07-30 14:53 UTC, Vinícius Zavam
no flags Details
[PATCH] sysutils/openipmi: update to 2.0.25 (21.30 KB, patch)
2018-08-09 19:04 UTC, Vinícius Zavam
no flags Details | Diff
[PATCH] sysutils/openipmi: update to 2.0.25 QA+ (23.03 KB, patch)
2018-08-23 20:46 UTC, Vinícius Zavam
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vinícius Zavam freebsd_committer 2018-07-26 09:20:19 UTC
Created attachment 195464 [details]
[PATCH] sysutils/openipmi: update to 2.0.25

Before submitting this patch I checked&tested #174545, D3568 and ports@r373974.

Did minor fixes to the Makefile (not using option helpers as I'd like to).

I also would like to adopt the port, if it's okay. Thanks.
Comment 1 Vinícius Zavam freebsd_committer 2018-07-26 09:23:20 UTC
Created attachment 195465 [details]
[LOG/10amd64] sysutils/openipmi: update to 2.0.25
Comment 2 Vinícius Zavam freebsd_committer 2018-07-26 09:23:36 UTC
Created attachment 195466 [details]
[LOG/11amd64] sysutils/openipmi: update to 2.0.25
Comment 3 Vinícius Zavam freebsd_committer 2018-07-26 09:33:41 UTC
Created attachment 195467 [details]
[LOG/10amd64] sysutils/openipmi: update to 2.0.25, ALL OPTIONS
Comment 4 Vinícius Zavam freebsd_committer 2018-07-26 09:33:57 UTC
Created attachment 195468 [details]
[LOG/11amd64] sysutils/openipmi: update to 2.0.25, ALL OPTIONS
Comment 5 Renato Botelho freebsd_committer 2018-07-26 23:21:44 UTC
When I tested it with all options ON (using gtk12) it failed complaining about a deprecated USES_PYTHON line. After remove that it also failed with the following error:

====> Running Q/A tests (stage-qa)
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/openipmigui'
Warning: /wrkdirs/usr/ports/sysutils/openipmi/work/stage/usr/local/lib/perl5/site_perl/mach/5.26/auto/OpenIPMI/OpenIPMI.so is not linked with libperl.so.5.26, not respecting lddlflags?
Error: None of the .so in /wrkdirs/usr/ports/sysutils/openipmi/work/stage/usr/local/lib/perl5/site_perl/mach/5.26 are linked with libperl.so.5.26, see above for the full list.

When you update patch please add you email to MAINTAINER line
Comment 6 Vinícius Zavam freebsd_committer 2018-07-27 15:03:40 UTC
(In reply to Renato Botelho from comment #5)

hi garga@,
thanks for the feedback. appreciated!

I should patch it ASAP. KR,
Comment 7 Vinícius Zavam freebsd_committer 2018-07-30 14:48:11 UTC
Created attachment 195637 [details]
[PATCH] sysutils/openipmi: update to 2.0.25

fix issues building against GLIB12.
Comment 8 Vinícius Zavam freebsd_committer 2018-07-30 14:49:01 UTC
Created attachment 195638 [details]
[LOG/11amd64] sysutils/openipmi: update to 2.0.25
Comment 9 Vinícius Zavam freebsd_committer 2018-07-30 14:52:00 UTC
Created attachment 195639 [details]
[LOG/10amd64] sysutils/openipmi: update to 2.0.25
Comment 10 Vinícius Zavam freebsd_committer 2018-07-30 14:53:05 UTC
Created attachment 195640 [details]
[LOG/11amd64] sysutils/openipmi: update to 2.0.25, ALL OPTIONS GLIB12
Comment 11 Vinícius Zavam freebsd_committer 2018-07-30 14:53:30 UTC
Created attachment 195641 [details]
[LOG/11amd64] sysutils/openipmi: update to 2.0.25, ALL OPTIONS GLIB20
Comment 12 Renato Botelho freebsd_committer 2018-08-09 11:48:42 UTC
Still failing if I select all options except GLIB12 / GLIB20.

====> Running Q/A tests (stage-qa)
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/openipmigui'
Warning: /wrkdirs/usr/ports/sysutils/openipmi/work/stage/usr/local/lib/perl5/site_perl/mach/5.26/auto/OpenIPMI/OpenIPMI.so is not linked with libperl.so.5.26, not respecting lddlflags?
Error: None of the .so in /wrkdirs/usr/ports/sysutils/openipmi/work/stage/usr/local/lib/perl5/site_perl/mach/5.26 are linked with libperl.so.5.26, see above for the full list.
*** Error code 1

Stop.
make: stopped in /usr/ports/sysutils/openipmi
=>> Error: stage-qa failures detected
build of sysutils/openipmi | openipmi-2.0.25 ended at Thu Aug  9 08:46:23 -03 2018
build time: 00:01:06
!!! build failure encountered !!!
[00:01:16] Error: Build failed in phase: stage-qa
[00:01:16] Cleaning up
[00:01:16] Unmounting file systems
Comment 13 Vinícius Zavam freebsd_committer 2018-08-09 18:01:49 UTC
(In reply to Renato Botelho from comment #12)

thank you for reporting back. very appreciated! I'll recheck it for both versions, and options combinations.
Comment 14 Vinícius Zavam freebsd_committer 2018-08-09 19:04:35 UTC
Created attachment 196034 [details]
[PATCH] sysutils/openipmi: update to 2.0.25


removed USE_PYTHON= from the Makefile; although it was still working fine for my test env, we opted to follow QA.

thanks garga!
Comment 15 Vinícius Zavam freebsd_committer 2018-08-23 20:46:12 UTC
Created attachment 196482 [details]
[PATCH] sysutils/openipmi: update to 2.0.25 QA+

root@11amd64-svn:~ # make -s -C /usr/ports/sysutils/openipmi stage-qa
====> Running Q/A tests (stage-qa)
/!\ To run stage-qa automatically add DEVELOPER=yes to your environment /!\

root@11amd64-svn:~ # make -s -C /usr/ports/sysutils/openipmi DEVELOPER=yes stage-qa
====> Running Q/A tests (stage-qa)

root@11amd64-svn:~ # echo $?
0
Comment 16 commit-hook freebsd_committer 2018-08-24 12:46:22 UTC
A commit references this bug:

Author: garga
Date: Fri Aug 24 12:46:09 UTC 2018
New revision: 477959
URL: https://svnweb.freebsd.org/changeset/ports/477959

Log:
  sysutils/openipmi: Update to 2.0.25

  Pass maintainership to submitter

  PR:		230052
  Submitted by:	Vin?cius Zavam <egypcio@googlemail.com>
  Sponsored by:	Rubicon Communications, LLC (Netgate)

Changes:
  head/sysutils/openipmi/Makefile
  head/sysutils/openipmi/distinfo
  head/sysutils/openipmi/files/extra-patch-glib_glib__os__hnd.c
  head/sysutils/openipmi/files/extra-patch-swig_perl_Makefile.in
  head/sysutils/openipmi/files/patch-OpenIPMIpthread.pc.in
  head/sysutils/openipmi/files/patch-configure
  head/sysutils/openipmi/files/patch-lanserv_extcmd.c
  head/sysutils/openipmi/files/patch-lib_rakp.c
  head/sysutils/openipmi/files/patch-swig_perl_Makefile.in
  head/sysutils/openipmi/pkg-plist