Bug 230140 - textproc/py-sphinx: Update to 1.8.1
Summary: textproc/py-sphinx: Update to 1.8.1
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: Marcelo Araujo
URL:
Keywords: needs-qa
Depends on:
Blocks: 233010
  Show dependency treegraph
 
Reported: 2018-07-29 06:03 UTC by Yuri Victorovich
Modified: 2018-11-08 20:17 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (araujo)
antoine: exp-run?


Attachments
patch (2.65 KB, patch)
2018-07-29 06:03 UTC, Yuri Victorovich
no flags Details | Diff
Updated patch (4.12 KB, patch)
2018-07-31 22:57 UTC, Yuri Victorovich
no flags Details | Diff
sphinx-1.8.1.diff (5.96 KB, patch)
2018-11-07 20:52 UTC, Li-Wen Hsu
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2018-07-29 06:03:56 UTC
Created attachment 195582 [details]
patch
Comment 1 Marcelo Araujo freebsd_committer 2018-07-30 03:04:03 UTC
LGTM, but could you ask to run an exprun over the ports tree? There are plenty of other ports that depends of py-sphinx!
Comment 2 Yuri Victorovich freebsd_committer 2018-07-30 03:41:54 UTC
portmgr, the maintainer requests the exprun.
Comment 3 Antoine Brodin freebsd_committer 2018-07-31 21:20:35 UTC
This is bad,  the dependencies of sphinx are not correct.  How was this tested?
Comment 4 Yuri Victorovich freebsd_committer 2018-07-31 22:57:07 UTC
Created attachment 195705 [details]
Updated patch

My bad, I didn't test dependencies.
Now I've built several dependencies fine.
Comment 5 Antoine Brodin freebsd_committer 2018-08-05 07:15:30 UTC
Around 30 ports were not tested due to new failures.

New failures:

+ {"origin"=>"devel/ahven", "phase"=>"build", "errortype"=>"bad_C++_code"}
+ {"origin"=>"devel/cmake-doc", "phase"=>"package", "errortype"=>"bad_C++_code"}
+ {"origin"=>"devel/kf5-extra-cmake-modules", "phase"=>"package", "errortype"=>"bad_C++_code"}
+ {"origin"=>"devel/llvm33", "phase"=>"package", "errortype"=>"bad_C++_code"}
+ {"origin"=>"devel/llvm34", "phase"=>"package", "errortype"=>"bad_C++_code"}
+ {"origin"=>"devel/llvm35", "phase"=>"package", "errortype"=>"bad_C++_code"}
+ {"origin"=>"devel/py-noseofyeti", "phase"=>"build", "errortype"=>"bad_C++_code"}
+ {"origin"=>"devel/py-pathtools", "flavor"=>"py36", "phase"=>"package", "errortype"=>"bad_C++_code"}
+ {"origin"=>"devel/py-pathtools", "phase"=>"package", "errortype"=>"bad_C++_code"}
+ {"origin"=>"devel/py-virtualenvwrapper", "phase"=>"package", "errortype"=>"bad_C++_code"}
+ {"origin"=>"devel/shiboken", "phase"=>"package", "errortype"=>"bad_C++_code"}
+ {"origin"=>"math/yacas", "phase"=>"build", "errortype"=>"bad_C++_code"}
+ {"origin"=>"net/py-gntp", "phase"=>"package", "errortype"=>"bad_C++_code"}
+ {"origin"=>"textproc/py-cloud_sptheme", "flavor"=>"py36", "phase"=>"build", "errortype"=>"bad_C++_code"}
+ {"origin"=>"textproc/py-cloud_sptheme", "phase"=>"build", "errortype"=>"bad_C++_code"}
+ {"origin"=>"www/py-cssselect", "flavor"=>"py36", "phase"=>"package", "errortype"=>"bad_C++_code"}
+ {"origin"=>"www/py-cssselect", "phase"=>"package", "errortype"=>"bad_C++_code"}

New failure logs:

http://package18.nyi.freebsd.org/data/104amd64-default-PR230140/2018-08-04_12h34m13s/logs/errors/ahven-2.6_4.log
http://package18.nyi.freebsd.org/data/104amd64-default-PR230140/2018-08-04_12h34m13s/logs/errors/cmake-doc-3.12.0.log
http://package18.nyi.freebsd.org/data/104amd64-default-PR230140/2018-08-04_12h34m13s/logs/errors/kf5-extra-cmake-modules-5.48.0.log
http://package18.nyi.freebsd.org/data/104amd64-default-PR230140/2018-08-04_12h34m13s/logs/errors/llvm33-3.3_14.log
http://package18.nyi.freebsd.org/data/104amd64-default-PR230140/2018-08-04_12h34m13s/logs/errors/llvm34-3.4.2_10.log
http://package18.nyi.freebsd.org/data/104amd64-default-PR230140/2018-08-04_12h34m13s/logs/errors/llvm35-3.5.2_8.log
http://package18.nyi.freebsd.org/data/104amd64-default-PR230140/2018-08-04_12h34m13s/logs/errors/py27-noseofyeti-1.5.1.log
http://package18.nyi.freebsd.org/data/104amd64-default-PR230140/2018-08-04_12h34m13s/logs/errors/py36-pathtools-0.1.2_4.log
http://package18.nyi.freebsd.org/data/104amd64-default-PR230140/2018-08-04_12h34m13s/logs/errors/py27-pathtools-0.1.2_4.log
http://package18.nyi.freebsd.org/data/104amd64-default-PR230140/2018-08-04_12h34m13s/logs/errors/py27-virtualenvwrapper-4.8.2_1.log
http://package18.nyi.freebsd.org/data/104amd64-default-PR230140/2018-08-04_12h34m13s/logs/errors/shiboken-1.2.2_3.log
http://package18.nyi.freebsd.org/data/104amd64-default-PR230140/2018-08-04_12h34m13s/logs/errors/yacas-1.6.0_3.log
http://package18.nyi.freebsd.org/data/104amd64-default-PR230140/2018-08-04_12h34m13s/logs/errors/py27-gntp-0.8_5.log
http://package18.nyi.freebsd.org/data/104amd64-default-PR230140/2018-08-04_12h34m13s/logs/errors/py36-cloud_sptheme-1.9.4.log
http://package18.nyi.freebsd.org/data/104amd64-default-PR230140/2018-08-04_12h34m13s/logs/errors/py27-cloud_sptheme-1.9.4.log
http://package18.nyi.freebsd.org/data/104amd64-default-PR230140/2018-08-04_12h34m13s/logs/errors/py36-cssselect-0.9.1_2.log
http://package18.nyi.freebsd.org/data/104amd64-default-PR230140/2018-08-04_12h34m13s/logs/errors/py27-cssselect-0.9.1_2.log
Comment 6 Yuri Victorovich freebsd_committer 2018-08-05 07:46:09 UTC
Some failures are due to the hardcoded Sphinx version in the file names. Some other failures are due to possible incompatible interface changes.

The maintainer needs to resolve this.

Thanks, Antoine!
Comment 7 Antoine Brodin freebsd_committer 2018-08-05 08:54:45 UTC
(In reply to Yuri Victorovich from comment #6)
No, you have to work with the maintainers to resolve this and propose a new patch for exp-run.
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2018-08-07 23:57:21 UTC
I also have a patch in flight for this. Any issues/bugs with ports that require changes there (in them), should be created as blocking sub-tasks to this issue.

@Marcelo Given the importance of this port for the python port ecosystem, would you mind if maintainership was changed to python@, either during or after this change? We do this for a number of other major/infrastructure ports (setuptools, pip, etc).
Comment 9 Marcelo Araujo freebsd_committer 2018-08-08 01:54:41 UTC
(In reply to Kubilay Kocak from comment #8)

I would not mind at all, if you have a patch under the way. you can update maintainership to python@, otherwise I don't see a reason to do that prior a patch.
Comment 10 Li-Wen Hsu freebsd_committer 2018-11-07 20:52:55 UTC
Created attachment 199063 [details]
sphinx-1.8.1.diff

Update patch to 1.8.1 and grab maintainership for python@

Also for textproc/py-sphinxcontrib-websupport because it is a direct dependency of textproc/py-sphinx
Comment 11 Li-Wen Hsu freebsd_committer 2018-11-07 20:54:09 UTC
Request exprun again
Comment 12 Antoine Brodin freebsd_committer 2018-11-07 21:00:38 UTC
Where is the patch for all previously detected failures?