Bug 230188 - misc/py-pexpect: update to 4.6.0
Summary: misc/py-pexpect: update to 4.6.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ruslan Makhmatkhanov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-30 12:06 UTC by Ruslan Makhmatkhanov
Modified: 2018-07-30 12:18 UTC (History)
1 user (show)

See Also:
wg: maintainer-feedback+


Attachments
pexpect 4.6.0 (803 bytes, patch)
2018-07-30 12:06 UTC, Ruslan Makhmatkhanov
no flags Details | Diff
build log (19.65 KB, text/plain)
2018-07-30 12:07 UTC, Ruslan Makhmatkhanov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ruslan Makhmatkhanov freebsd_committer 2018-07-30 12:06:12 UTC
Created attachment 195630 [details]
pexpect 4.6.0

async is the registered keyword since python 3.7, so current version of pexpect fails to work with py37:

  File "/usr/local/lib/python3.7/site-packages/pexpect/spawnbase.py", line 224
    def expect(self, pattern, timeout=-1, searchwindowsize=-1, async=False):
                                                                   ^
SyntaxError: invalid syntax
*** Error code 1

Update to latest version solves the issue.
Comment 1 Ruslan Makhmatkhanov freebsd_committer 2018-07-30 12:07:10 UTC
Created attachment 195631 [details]
build log
Comment 2 William Grzybowski freebsd_committer 2018-07-30 12:08:25 UTC
Approved. Feel free to take maintainership if you would like.

Thanks.
Comment 3 Ruslan Makhmatkhanov freebsd_committer 2018-07-30 12:13:33 UTC
Thanks! I won't, but I may pass maintainership to python@ if you would like to.
Comment 4 William Grzybowski freebsd_committer 2018-07-30 12:14:02 UTC
Sure, thats fine with me.
Comment 5 commit-hook freebsd_committer 2018-07-30 12:17:36 UTC
A commit references this bug:

Author: rm
Date: Mon Jul 30 12:16:56 UTC 2018
New revision: 475883
URL: https://svnweb.freebsd.org/changeset/ports/475883

Log:
  misc/py-pexpect: update to 4.6.0

  async is the registered keyword since python 3.7, so current version of pexpect
  fails to work with py37:

    File "/usr/local/lib/python3.7/site-packages/pexpect/spawnbase.py", line 224
      def expect(self, pattern, timeout=-1, searchwindowsize=-1, async=False):
                                                                     ^
  SyntaxError: invalid syntax
  *** Error code 1

  Update to latest version solves the issue.

  Also pass maintainership to python@ at maintainer's request

  PR:		230188
  Approved by:	wg (maintainer)

Changes:
  head/misc/py-pexpect/Makefile
  head/misc/py-pexpect/distinfo
Comment 6 Ruslan Makhmatkhanov freebsd_committer 2018-07-30 12:18:29 UTC
Done, thanks.