Created attachment 195840 [details] Update Changes: https://github.com/hills/xosview/commit/acef3cde0b53e46e00cc53c170602d7ee04788ba Portlint OK
Created attachment 195841 [details] Poudriere Log 10.4-Release
Created attachment 195842 [details] Poudriere Log 11.2-Stable
This new version shows this message when I try to run it: [ota@nostromo /usr/home/ota]$ xosview xosview: OpenKDIfNeeded(): /dev/mem: Permission denied: Permission denied [ota@nostromo /usr/home/ota]$ The problem doesn't occur on the old version. Maybe needs a more specific patch?
Hi Nathan, (1) bin/xosview entry in PLIST_FILES is missing ownership specification "@(,kmem,2555)", hence the permission issues. BTW, why the move to PLIST_FILES? pkg-plist looks fine to me. (2) If you decide to go with PLIST_FILES, pkg-plist needs to be removed. It's either PLIST_FILES or pkg-plist. `portlint -AC` and `make package` warn about this. (3) Why the need for LIB_DEPENDS=libkvm.so:misc/compat10x ?
(In reply to Dmitri Goutnik from comment #4) > Hi Nathan, > > (1) bin/xosview entry in PLIST_FILES is missing ownership specification > "@(,kmem,2555)", hence the permission issues. BTW, why the move to > PLIST_FILES? pkg-plist looks fine to me. > > (2) If you decide to go with PLIST_FILES, pkg-plist needs to be removed. > It's either PLIST_FILES or pkg-plist. `portlint -AC` and `make package` warn > about this. > > (3) Why the need for LIB_DEPENDS=libkvm.so:misc/ Used plist bc it’s less than 6 files as portlint complains about that. Working on fixing the permissions. I tested it but ofc poudriere interactive puts shell in to root
Created attachment 195952 [details] Update
The patch looks OK to me. Another guy must commit it because I don't have commit bit.
Take
This is broken in 12-CURRENT due to changes in sys/vmmeter.h https://svnweb.freebsd.org/base/head/sys/sys/vmmeter.h?r1=328134&r2=328954
The xosview version 1.19 is also broken on FreeBSD 12. Is it necessary to fix the build on FreeBSD 12 to perform the commit? Now is the second time that xosview has broken in FreeBSD 12 because of modifications in source code. I was waiting for the code freeze to address this problem on 12.
(In reply to otacilio.neto from comment #10) >The xosview version 1.19 is also broken on FreeBSD 12. Is it necessary to >fix the build on FreeBSD 12 to perform the commit? Not strictly necessary but I was surprised it was not marked as BROKEN. It is not surprising though that this happens since xosview peeks into internal data structures. I had a look at the problem but I don't have the necessary knowledge about how the statistics are calculated to try and find some equivalent values to those that are now missing. I created a review for this PR: https://reviews.freebsd.org/D16710
A commit references this bug: Author: fernape Date: Wed Aug 15 16:42:38 UTC 2018 New revision: 477239 URL: https://svnweb.freebsd.org/changeset/ports/477239 Log: sysutils/xosview: update to 1.20 Mark as BROKEN in 12 PR: 230351 Submitted by: ndowens@yahoo.com Approved by: tcberner (mentor) Differential Revision: https://reviews.freebsd.org/D16710 Changes: head/sysutils/xosview/Makefile head/sysutils/xosview/distinfo head/sysutils/xosview/files/patch-bsd_kernel.cc head/sysutils/xosview/pkg-plist
Committed, Thanks!