Bug 230390 - audio/xmms-faad: Update to 2.8.8
Summary: audio/xmms-faad: Update to 2.8.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
Depends on:
Reported: 2018-08-05 19:56 UTC by Nathan
Modified: 2018-08-06 05:54 UTC (History)
0 users

See Also:

Update (2.88 KB, patch)
2018-08-05 19:56 UTC, Nathan
ndowens04: maintainer-approval+
Details | Diff
Poudriere Log 11.2-Stable (26.73 KB, text/plain)
2018-08-05 19:57 UTC, Nathan
no flags Details
Poudriere Log 10.4-Release (32.76 KB, patch)
2018-08-05 19:59 UTC, Nathan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan 2018-08-05 19:56:30 UTC
Created attachment 195911 [details]

Couldn't find changelog for this version, closest I could find is for 2.7:
Change­Log for FAAD2 2.7:

    DAB+ sup­port
    Use pub­lic head­ers in­tern­al­ly to pre­vent dup­li­ca­te dec­la­ra­tions
    Ex­plic­it­ly ty­pe­def all ty­pes as sign­ed
    Made sure MAIN pre­dic­ti­on can't be star­ted af­ter the first fra­me
    Lot's of com­pi­la­ti­on is­sues sol­ved
    Bug­fix in SBR en­ve­lo­pe bor­der cal­cu­la­ti­on

Portlint: OK
Comment 1 Nathan 2018-08-05 19:57:06 UTC
Created attachment 195912 [details]
Poudriere Log 11.2-Stable
Comment 2 Nathan 2018-08-05 19:59:05 UTC
Created attachment 195913 [details]
Poudriere Log 10.4-Release
Comment 3 Nathan 2018-08-06 05:23:44 UTC
Comment on attachment 195911 [details]

Unmaintained: Implicit Approval
Comment 4 commit-hook freebsd_committer 2018-08-06 05:50:37 UTC
A commit references this bug:

Author: tobik
Date: Mon Aug  6 05:50:10 UTC 2018
New revision: 476490
URL: https://svnweb.freebsd.org/changeset/ports/476490

  audio/xmms-faad: Update to 2.8.8

  PR:		230390
  Submitted by:	Nathan <ndowens@gmx.us> (based on)

Comment 5 Tobias Kortkamp freebsd_committer 2018-08-06 05:54:38 UTC
Committed with some changes. Thanks!

- xmms-faad is an XMMS plugin and should not install libfaad.3,
  which is just API documentation for audio/faad.  audio/faad should
  be changed to install it (audio/{faad,xmms-faad} share a distfile).
  Open a new PR for it!

- Do not introduce new non-standard variables (i.e.  WRKSRCDIR),
  when standard variables will do.  Here BUILD_WRKSRC could have
  been set for just the build phase.  (Since libfaad.3 is not
  being installed now it's not necessary anymore though.)

- USE_LDCONFIG is not necessary here (portlint is sometimes wrong).
  The port installs a plugin that is directly dlopened by XMMS.