Bug 230424 - [NEW PORT] graphics/py-glfw: Python bindings for GLFW
Summary: [NEW PORT] graphics/py-glfw: Python bindings for GLFW
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords: feature, needs-qa
Depends on:
Blocks:
 
Reported: 2018-08-07 02:43 UTC by Neel Chauhan
Modified: 2019-02-05 12:58 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback+

Attachments
Shar file (Revision 1) (1.52 KB, text/plain)
2018-08-07 02:43 UTC, Neel Chauhan 		no flags Details
Patch (Revision 2) (1.47 KB, text/plain)
2018-08-07 03:28 UTC, Neel Chauhan 		no flags Details
Shar file (Revision 3) (1.52 KB, text/plain)
2018-11-24 20:02 UTC, Neel Chauhan 		no flags Details
Shar file (Revision 4) (1.50 KB, text/plain)
2019-02-04 19:14 UTC, Neel Chauhan 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Neel Chauhan freebsd_committer freebsd_triage 2018-08-07 02:43:34 UTC 
Created attachment 195960 [details]
Shar file (Revision 1)

pyGLFW provides Python bindings for GLFW. It is a ctypes wrapper which aims to
be very close to the original GLFW API.

WWW: https://github.com/FlorianRhiem/pyGLFW
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2018-08-07 02:54:05 UTC 
Thanks Neel,

Review items:

- Use CHEESESHOP for MASTER_SITES unless there's a compelling temporary reason to use an alternate source for distribution files (like GiHub), such as missing test/data files, etc. In these cases please ask upstream to include them in the PyPI source distribution (sdist)

- Add python as a secondary entry to CATEGORIES for all python packages, particular those distributed in PyPI

- Match the COMMENT of the port to the setup.py:description where possible, portlint compliance not withstanding (this package has "ctypes-based wrapper for GLFW3"

- Add LICENSE_FILE where a license file is provided with the distribution file (this packages PyPI sdist contains LICENSE.txt)

Please also confirm that this port passes QA (portlint, poudriere in particular)
Comment 2 Neel Chauhan freebsd_committer freebsd_triage 2018-08-07 03:28:34 UTC 
Created attachment 195962 [details]
Patch (Revision 2)

I have made the changes. Also, this port (including the original version) passes Poudriere.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2018-08-07 03:50:04 UTC 
(In reply to Neel Chauhan from comment #2)

Thank you Neel
Comment 4 Neel Chauhan freebsd_committer freebsd_triage 2018-11-24 20:02:40 UTC 
Created attachment 199522 [details]
Shar file (Revision 3)

I'm renaming this port graphics/py-pyglfw
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2018-11-28 06:07:01 UTC 
(In reply to Neel Chauhan from comment #4)

This packages canonical name is glfw (https://pypi.org/project/glfw/)

pyglfw is a different and separate package, canonically registered as such (https://pypi.org/project/pyglfw/)
Comment 6 Tobias Kortkamp freebsd_committer freebsd_triage 2019-02-04 19:11:15 UTC 
Ping?  Can you name the port as koobs has suggested in comment #5 i.e. py-glfw?
1.7.1 was just released two days ago too.
Comment 7 Neel Chauhan freebsd_committer freebsd_triage 2019-02-04 19:14:53 UTC 
Created attachment 201729 [details]
Shar file (Revision 4)

I updated the shar to graphics/py-glfw and it's now version 1.7.1.
Comment 8 commit-hook freebsd_committer freebsd_triage 2019-02-05 12:58:11 UTC 
A commit references this bug:

Author: tobik
Date: Tue Feb  5 12:57:59 UTC 2019
New revision: 492206
URL: https://svnweb.freebsd.org/changeset/ports/492206

Log:
  New port: graphics/py-glfw

  pyGLFW provides Python bindings for GLFW.  It is a ctypes wrapper
  which aims to be very close to the original GLFW API.

  WWW: https://github.com/FlorianRhiem/pyGLFW

  PR:		230424
  Submitted by:	neel@neelc.org
  Reviewed by:	koobs

Changes:
  head/graphics/Makefile
  head/graphics/py-glfw/
  head/graphics/py-glfw/Makefile
  head/graphics/py-glfw/distinfo
  head/graphics/py-glfw/pkg-descr