Created attachment 195967 [details]
* Update to 0.16.2
* Relnotes https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-0.16.2.md
* Switch away from using GitHub source tarballs per messages on https://github.com/bitcoin/bitcoin/releases about deterministic tarballs. The source has a SHA256 file that is GPG signed for verification with our ports SHA256.
portlint is currently broken on my machine (perl?) so I can't verify the Makefile variables are in correct order, please correct during commit if it's something trivial.
For the last bullet point above I meant to say the mastersite directory has a SHA256 file with integral GPG info https://bitcoincore.org/bin/bitcoin-core-0.16.2/SHA256SUMS.asc
Reporter is maintainer (and committer, no?), assign accordingly
Created attachment 195969 [details]
The deterministic files lack the freedesktop stuff we were using. Add it to files/. I will also be uploading a 12KB binary image bitcoin128.png that should also go in files/bitcoin128.png unless there is some better method of distributing this.
Created attachment 195970 [details]
freedesktop icon we were using not included in deterministic tarball
(In reply to Kevin Bowling from comment #4)
Is there a URL where we could fetch this?
(In reply to Steve Wills from comment #5)
Not sure of a reliable distribution point, it is there in the git repo still just not in the cmake driven tarball.
(In reply to Kevin Bowling from comment #6)
I'll copy it to my local distfiles and use LOCAL.
Created attachment 196401 [details]
Updated patch with icon being fetched from LOCAL distfiles
Here's an updated patch with the icon being fetched from the LOCAL distfiles. Look good?
Looks good assuming you will do the file add https://bugs.freebsd.org/bugzilla/attachment.cgi?id=195969&action=diff#b/net-p2p/bitcoin/files/bitcoin-qt.desktop_sec1
A commit references this bug:
Date: Wed Aug 22 15:33:57 UTC 2018
New revision: 477794
net-p2p/bitcoin: Update to 0.16.2
Submitted by: kbowling (maintainer)