Bug 230489 - [patch] bin/cat compiled with -DNO_UDOM_SUPPORT will fail to compile as it is missing #include <errno.h>
Summary: [patch] bin/cat compiled with -DNO_UDOM_SUPPORT will fail to compile as it is...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 11.2-RELEASE
Hardware: Any Any
: --- Affects Some People
Assignee: Ed Maste
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-08-09 23:23 UTC by will.senn
Modified: 2018-08-14 01:59 UTC (History)
2 users (show)

See Also:

Attachments
patch to cat.c to include errno.h for all paths (346 bytes, text/plain)
2018-08-09 23:23 UTC, will.senn 		no flags Details
patch to cat.c to include errno.h for all paths (346 bytes, patch)
2018-08-09 23:30 UTC, will.senn 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description will.senn 2018-08-09 23:23:48 UTC 
Created attachment 196038 [details]
patch to cat.c to include errno.h for all paths

#include <errno.h> is required by all conditions.
Comment 1 will.senn 2018-08-09 23:30:07 UTC 
Created attachment 196039 [details]
patch to cat.c to include errno.h for all paths

got old and new reversed on prior attachment, apologies - first bug report... ever.
Comment 2 Maxim Konovalov freebsd_committer freebsd_triage 2018-08-10 10:22:36 UTC 
Hi Will,

that was fixed a year ago by emaste@, see the commit:

https://svnweb.freebsd.org/base?view=revision&revision=322325

I'll reassign the ticket to him.

Thanks for the report.

Maxim
Comment 3 Maxim Konovalov freebsd_committer freebsd_triage 2018-08-10 10:24:45 UTC 
Hi Ed,

This is a bug report for the issue that you fixed a year ago for your consideration.

Maxim
Comment 4 will.senn 2018-08-10 13:49:42 UTC 
Hi Maxim,

I see that I should have checked against current source rather than just trying to find it in the bug database. Yes, the fix by Ed fully addressed the issue.

Will
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-08-14 01:45:52 UTC 
A commit references this bug:

Author: kevans
Date: Tue Aug 14 01:45:22 UTC 2018
New revision: 337733
URL: https://svnweb.freebsd.org/changeset/base/337733

Log:
  MFC r322325: cat: fix build with -DNO_UDOM_SUPPORT

  PR:		230489

Changes:
_U  stable/11/
  stable/11/bin/cat/cat.c
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-08-14 01:58:03 UTC 
A commit references this bug:

Author: kevans
Date: Tue Aug 14 01:57:11 UTC 2018
New revision: 337734
URL: https://svnweb.freebsd.org/changeset/base/337734

Log:
  MFC r322325: cat: fix build with -DNO_UDOM_SUPPORT

  PR:		230489

Changes:
_U  stable/10/
  stable/10/bin/cat/cat.c
Comment 7 Kyle Evans freebsd_committer freebsd_triage 2018-08-14 01:59:18 UTC 
Hi,

I went ahead and merged this to stable/11 and stable/10. As it is now present in all stable branches, I'm going to go ahead and close this as 'FIXED'.

Thanks for the submission! =)

Kyle Evans