Bug 230502 - games/flightgear: fails to build with clang 7
Summary: games/flightgear: fails to build with clang 7
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ganael LAPLANCHE
URL:
Keywords: needs-patch
Depends on:
Blocks: 230355
  Show dependency treegraph
 
Reported: 2018-08-10 13:14 UTC by Jan Beich
Modified: 2018-08-20 22:50 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (martymac)


Attachments
First patch attempt (1.10 KB, patch)
2018-08-20 20:36 UTC, Ganael LAPLANCHE
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2018-08-10 13:14:25 UTC
$ poudriere jail -cj clang7 -a amd64 -v projects/clang700-import -m svn+https
$ poudriere testport -j clang7 games/flightgear
[...]
src/AIModel/AIFlightPlanCreatePushBack.cxx:96:48: error: ordered comparison between pointer and zero ('FGTaxiNode *' and 'int')
    if (parking && parking->getPushBackPoint() > 0) {
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~

buid log: https://ptpb.pw/QTXC
Comment 1 Ganael LAPLANCHE freebsd_committer 2018-08-11 16:24:52 UTC
Thanks for your report.

I'll be able to take a look at this within one or two weeks.

Best regards,
Ganael.
Comment 2 Ganael LAPLANCHE freebsd_committer 2018-08-20 20:36:55 UTC
Created attachment 196400 [details]
First patch attempt
Comment 3 Ganael LAPLANCHE freebsd_committer 2018-08-20 20:37:26 UTC
Hi Jan,

Unfortunately my poudriere box is still running 11.2 and building packages for 12-CURRENT does not work anymore (python 2.7 cannot be built).

Would the attached patch be enough to fix the problem ?
Comment 4 Jan Beich freebsd_committer 2018-08-20 22:50:05 UTC
Comment on attachment 196400 [details]
First patch attempt

In file included from src/FDM/UIUCModel/uiuc_gear.cpp:72:
In file included from src/FDM/UIUCModel/uiuc_gear.h:4:
In file included from src/FDM/UIUCModel/uiuc_aircraft.h:150:
src/FDM/UIUCModel/uiuc_parsefile.h:26:17: error: reference to 'stack' is ambiguous
                stack commands;
                ^
src/FDM/UIUCModel/uiuc_parsefile.h:20:22: note: candidate found by name lookup is 'stack'
typedef list<string> stack; //list to contain the input file "command_lines"
                     ^
/usr/include/c++/v1/stack:113:28: note: candidate found by name lookup is 'std::__1::stack'
class _LIBCPP_TEMPLATE_VIS stack
                           ^
In file included from src/FDM/UIUCModel/uiuc_gear.cpp:72:
In file included from src/FDM/UIUCModel/uiuc_gear.h:4:
In file included from src/FDM/UIUCModel/uiuc_aircraft.h:150:
src/FDM/UIUCModel/uiuc_parsefile.h:40:17: error: reference to 'stack' is ambiguous
                stack getCommands();
                ^
src/FDM/UIUCModel/uiuc_parsefile.h:20:22: note: candidate found by name lookup is 'stack'
typedef list<string> stack; //list to contain the input file "command_lines"
                     ^
/usr/include/c++/v1/stack:113:28: note: candidate found by name lookup is 'std::__1::stack'
class _LIBCPP_TEMPLATE_VIS stack
                           ^
In file included from src/FDM/UIUCModel/uiuc_gear.cpp:72:
In file included from src/FDM/UIUCModel/uiuc_gear.h:4:
src/FDM/UIUCModel/uiuc_aircraft.h:153:9: error: reference to 'stack' is ambiguous
typedef stack :: iterator LIST;
        ^
src/FDM/UIUCModel/uiuc_parsefile.h:20:22: note: candidate found by name lookup is 'stack'
typedef list<string> stack; //list to contain the input file "command_lines"
                     ^
/usr/include/c++/v1/stack:113:28: note: candidate found by name lookup is 'std::__1::stack'
class _LIBCPP_TEMPLATE_VIS stack
                           ^
In file included from src/FDM/UIUCModel/uiuc_gear.cpp:72:
In file included from src/FDM/UIUCModel/uiuc_gear.h:4:
src/FDM/UIUCModel/uiuc_aircraft.h:153:18: error: use of class template 'iterator' requires template arguments
typedef stack :: iterator LIST;
                 ^
/usr/include/c++/v1/iterator:521:29: note: template is declared here
struct _LIBCPP_TEMPLATE_VIS iterator
                            ^
4 errors generated.

build log: https://ptpb.pw/L7aF