Bug 230514 - security/py-yubikey-manager: Update to 0.7.1; Take MAINTAINER'ship
Summary: security/py-yubikey-manager: Update to 0.7.1; Take MAINTAINER'ship
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://raw.githubusercontent.com/Yub...
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2018-08-10 22:46 UTC by Nathan
Modified: 2018-09-02 04:41 UTC (History)
3 users (show)

See Also:


Attachments
Update (2.21 KB, patch)
2018-08-10 22:46 UTC, Nathan
koobs: maintainer-approval-
Details | Diff
Update (2.55 KB, patch)
2018-08-11 02:55 UTC, Nathan
ndowens04: maintainer-approval+
Details | Diff
Update (2.56 KB, patch)
2018-08-11 03:29 UTC, Nathan
koobs: maintainer-approval-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan 2018-08-10 22:46:27 UTC
Created attachment 196067 [details]
Update

Portlint(looks fine)
Used poudriere on 11.2-Stable-AMD64 for 11.2-Release
Built and ran fine
Comment 1 Danilo G. Baio freebsd_committer freebsd_triage 2018-08-10 22:56:56 UTC
Hi.
Why locking this port to use only Python 2.7?
Comment 2 Nathan 2018-08-10 22:59:32 UTC
(In reply to Danilo G. Baio from comment #1)
> Hi.
> Why locking this port to use only Python 2.7?

It was giving openssl was only py2.7 but I will update patch later today, so WIP atm
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2018-08-10 23:07:02 UTC
Reviewed this with Nathan on IRC. Will provide update later.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2018-08-10 23:07:32 UTC
Comment on attachment 196067 [details]
Update

Needs changes and further review
Comment 5 Nathan 2018-08-11 02:55:03 UTC
Created attachment 196069 [details]
Update
Comment 6 Nathan 2018-08-11 03:18:07 UTC
Comment on attachment 196069 [details]
Update

>security/py-yubikey-manager: Update to 0.7.1
>
>* Updated to version 0.7.1
>* Corrected License according to COPYING file
>* Added pkg-message pertaining to Python 3
>  -- UTF Locale needs to be set in Python 3
>
>Changelog: https://raw.githubusercontent.com/Yubico/yubikey-manager/5938d59e84b139f357a7f9502fa027db3877c7f5/NEWS
>
>Index: security/py-yubikey-manager/Makefile
>===================================================================
>--- security/py-yubikey-manager/Makefile	(revision 476788)
>+++ security/py-yubikey-manager/Makefile	(working copy)
>@@ -1,15 +1,16 @@
> # $FreeBSD$
> 
> PORTNAME=	yubikey-manager
>-PORTVERSION=	0.6.1
>+PORTVERSION=	0.7.1
> CATEGORIES=	security python
> MASTER_SITES=	CHEESESHOP
> PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
> 
>-MAINTAINER=	ports@FreeBSD.org
>+MAINTAINER=	ndowens@yahoo.com
> COMMENT=	Python library and command line tool for configuring a YubiKey
> 
>-LICENSE=	GPLv3
>+LICENSE=	BSD2CLAUSE
>+LICENSE_FILE=	${WRKSRC}/COPYING
> 
> RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}pyscard>0:security/py-pyscard@${PY_FLAVOR} \
> 		${PYTHON_PKGNAMEPREFIX}pycrypto>0:security/py-pycrypto@${PY_FLAVOR} \
>@@ -20,7 +21,8 @@
> 		u2f-host:security/libu2f-host \
> 		ykpers>0:security/ykpers
> 
>-USES=		python:3.4+
>+USES=		python
> USE_PYTHON=	autoplist distutils
>+NO_ARCH=	yes
> 
> .include <bsd.port.mk>
>Index: security/py-yubikey-manager/distinfo
>===================================================================
>--- security/py-yubikey-manager/distinfo	(revision 476788)
>+++ security/py-yubikey-manager/distinfo	(working copy)
>@@ -1,3 +1,3 @@
>-TIMESTAMP = 1524469668
>-SHA256 (yubikey-manager-0.6.1.tar.gz) = bd5400b4bd246b3e3aa04e76e4fc665d92389709d6574d2244e3c94a12fe16ad
>-SIZE (yubikey-manager-0.6.1.tar.gz) = 78915
>+TIMESTAMP = 1533955267
>+SHA256 (yubikey-manager-0.7.1.tar.gz) = 177bbf953b8557b8de68bacbbdfc56764e93733f337b2327e322cfc4ed4f7d18
>+SIZE (yubikey-manager-0.7.1.tar.gz) = 71834
>Index: security/py-yubikey-manager/pkg-message
>===================================================================
>--- security/py-yubikey-manager/pkg-message	(nonexistent)
>+++ security/py-yubikey-manager/pkg-message	(working copy)
>@@ -0,0 +1,8 @@
>+
>+If using Python3.x:
>+You must export your UTF-8 locale, for ykman to run
>+
>+Example:
>+export LC_ALL=en_US.UTF-8
>+
>+
>
>Property changes on: security/py-yubikey-manager/pkg-message
>___________________________________________________________________
>Added: fbsd:nokeywords
>## -0,0 +1 ##
>+yes
>\ No newline at end of property
>Added: svn:eol-style
>## -0,0 +1 ##
>+native
>\ No newline at end of property
>Added: svn:mime-type
>## -0,0 +1 ##
>+text/plain
>\ No newline at end of property
Comment 7 Nathan 2018-08-11 03:29:21 UTC
Created attachment 196070 [details]
Update
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2018-08-11 03:51:21 UTC
Review items:

- Needs USE_PYTHON=concurrent (installs setup.py:console_scripts)
- Add TEST_DEPENDS and test target
- Re-add updated dependencies (missing)
Comment 9 Nathan 2018-08-16 22:26:52 UTC
Havent been able to get tests to work, might be because enum34 is only available for py27 and this port requires py3+

(In reply to Kubilay Kocak from comment #8)
> Review items:
> 
> - Needs USE_PYTHON=concurrent (installs setup.py:console_scripts)
> - Add TEST_DEPENDS and test target
> - Re-add updated dependencies (missing)