Bug 230516 - security/klee: depends on obsolete llvm38
Summary: security/klee: depends on obsolete llvm38
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Gleb Popov
URL:
Keywords:
Depends on:
Blocks: 230468
  Show dependency treegraph
 
Reported: 2018-08-10 23:09 UTC by Mark Linimon
Modified: 2019-03-26 04:39 UTC (History)
4 users (show)

See Also:
arrowd: maintainer-feedback+


Attachments
Upgrade to latest and switch to llvm60 (1.27 KB, patch)
2019-03-20 23:06 UTC, Brooks Davis
no flags Details | Diff
Updated patch (2.11 KB, patch)
2019-03-25 13:43 UTC, Gleb Popov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Linimon freebsd_committer freebsd_triage 2018-08-10 23:09:01 UTC

    
Comment 1 Gleb Popov freebsd_committer freebsd_triage 2018-08-11 08:28:44 UTC
According to https://github.com/klee/klee/issues/939 the latest release doesn't even support 3.8. Github page has pull request that adds 6.0 support, but it isn't merged yet.

KLEE always tried to support as many LLVM versions as possible, so it was always slacking behind current LLVM releases. My plan was to fork the project and merge support for 6.0 myself (as well as some other FreeBSD fixes I already done), but yuri took the initiative.

If the forking plan sounds OK, I'll try to resolve this in near future.
Comment 2 Brooks Davis freebsd_committer freebsd_triage 2018-11-12 17:21:24 UTC
It looks like llvm 6.0 support was merged a couple weeks ago so the next release should support it https://github.com/klee/klee/pull/894.
Comment 3 Brooks Davis freebsd_committer freebsd_triage 2019-03-20 20:10:40 UTC
The new klee release now support llvm 6.0.  It would be nice if they had jumped to 8.0, but at least we can get 3.8 out of the tree soon.
Comment 4 Brooks Davis freebsd_committer freebsd_triage 2019-03-20 23:06:57 UTC
Created attachment 203015 [details]
Upgrade to latest and switch to llvm60

The attached patch upgrades to the Klee 2.0 release and switches to llvm60.

It compiles for me, but is otherwise untested.
Comment 5 Gleb Popov freebsd_committer freebsd_triage 2019-03-22 08:57:54 UTC
The port does seem to work (modulo pkg-plist adjustements).

However, according to release notes, KLEE 2.0 supports LLVM 7 and 8 too. Should I bump the dependency directly to 8?
Comment 6 Brooks Davis freebsd_committer freebsd_triage 2019-03-22 15:53:05 UTC
(In reply to Gleb Popov from comment #5)
 
I missed that there was support for 7.0 and 8.0.  In that case, I might suggest bumping to LLVM_DEFAULT (if can be downgraded to 8.0 if that's required when 9.0 becomes the default).  I'd like to get most ports moved to LLVM_DEFAULT so a single round of exp-runs covers most version bumps.
Comment 7 Gleb Popov freebsd_committer freebsd_triage 2019-03-25 13:43:04 UTC
Created attachment 203133 [details]
Updated patch

Patch with fixed pkg-plist and LLVM_VERSION switched to LLVM_DEFAULT.
Comment 8 Tobias C. Berner freebsd_committer freebsd_triage 2019-03-25 19:59:16 UTC
@arrowd looks good to me.
Comment 9 commit-hook freebsd_committer freebsd_triage 2019-03-26 04:39:32 UTC
A commit references this bug:

Author: arrowd
Date: Tue Mar 26 04:38:53 UTC 2019
New revision: 496875
URL: https://svnweb.freebsd.org/changeset/ports/496875

Log:
  security/klee: Update to 2.0 and switch to LLVM 8.

  PR:		230516
  Submitted by:	brooks
  Approved by:	tcberner (mentor)

Changes:
  head/security/klee/Makefile
  head/security/klee/distinfo
  head/security/klee/pkg-plist