Bug 230527 - databases/mysql57-server: 5.7.23 fix build with LibreSSL 2.7
Summary: databases/mysql57-server: 5.7.23 fix build with LibreSSL 2.7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Mahdi Mokhtari
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-08-11 12:19 UTC by Markus Kohlmeyer
Modified: 2018-08-14 14:21 UTC (History)
0 users

See Also:
mmokhi: maintainer-feedback+


Attachments
patch-sql_mysqld.cc (400 bytes, patch)
2018-08-11 12:19 UTC, Markus Kohlmeyer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Kohlmeyer 2018-08-11 12:19:38 UTC
Created attachment 196078 [details]
patch-sql_mysqld.cc

This patch fixes a build error with LibreSSL 2.7:

[ 97%] Building CXX object sql/CMakeFiles/sql.dir/mysqld_thd_manager.cc.o
cd /usr/ports/databases/mysql57-server/work/.build/sql && /usr/bin/c++  -DGTEST_USE_OWN_TR1_TUPLE=1 -DHAVE_CONFIG_H -DHAVE_LIBEVENT2 -DHAVE_OPENSSL -DHAVE_REPLICATION -DMYSQL_SERVER -I/usr/ports/databases/mysql57-server/work/.build/include -I/usr/ports/databases/mysql57-server/work/mysql-5.7.23/extra/rapidjson/include -I/usr/ports/databases/mysql57-server/work/.build/libbinlogevents/include -I/usr/ports/databases/mysql57-server/work/mysql-5.7.23/libbinlogevents/export -I/usr/ports/databases/mysql57-server/work/mysql-5.7.23/include -I/usr/ports/databases/mysql57-server/work/mysql-5.7.23/sql/conn_handler -I/usr/ports/databases/mysql57-server/work/mysql-5.7.23/libbinlogevents/include -I/usr/ports/databases/mysql57-server/work/mysql-5.7.23/sql -I/usr/ports/databases/mysql57-server/work/mysql-5.7.23/sql/auth -I/usr/ports/databases/mysql57-server/work/mysql-5.7.23/regex -I/usr/local/include -I/usr/ports/databases/mysql57-server/work/.build/sql -I/usr/ports/databases/mysql57-server/work/.build -isystem /usr/ports/databases/mysql57-server/work/mysql-5.7.23/include/boost_1_59_0/patches -isystem /usr/ports/databases/mysql57-server/work/mysql-5.7.23/boost/boost_1_59_0 -O2 -pipe -fstack-protector -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include -Wall -Wextra -Wformat-security -Wvla -Woverloaded-virtual -Wno-unused-parameter -Wno-null-conversion -Wno-unused-private-field -O2 -pipe -fstack-protector -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include -DDBUG_OFF -fPIC -o CMakeFiles/sql.dir/mysqld_thd_manager.cc.o -c /usr/ports/databases/mysql57-server/work/mysql-5.7.23/sql/mysqld_thd_manager.cc
--- sql/CMakeFiles/sql.dir/mysqld.cc.o ---
/usr/ports/databases/mysql57-server/work/mysql-5.7.23/sql/mysqld.cc:3414:3: error: use of undeclared identifier 'OPENSSL_malloc_init'
  OPENSSL_malloc_init();
  ^
Comment 1 Markus Kohlmeyer 2018-08-11 12:23:32 UTC
IMHO this patch should be send to upstream.
Comment 2 commit-hook freebsd_committer 2018-08-11 17:53:19 UTC
A commit references this bug:

Author: mmokhi
Date: Sat Aug 11 17:52:23 UTC 2018
New revision: 476934
URL: https://svnweb.freebsd.org/changeset/ports/476934

Log:
  mysql57-server: Fix build with LibreSSL 2.7

  PR:		230527
  Submitted by:	Markus Kohlmeyer <rootservice@gmail.com>
  Reported by:	Markus Kohlmeyer <rootservice@gmail.com>
  Sponsored by:	The FreeBSD Foundation

Changes:
  head/databases/mysql57-server/Makefile
  head/databases/mysql57-server/files/patch-sql_mysqld.cc
Comment 3 Mahdi Mokhtari freebsd_committer freebsd_triage 2018-08-11 17:55:14 UTC
Thanks Markus for the point,
Just as note, I periodically ping guys at MySQL to upstream patches, will do it too hopefully asap :D
Comment 4 commit-hook freebsd_committer 2018-08-14 14:21:33 UTC
A commit references this bug:

Author: mmokhi
Date: Tue Aug 14 14:20:31 UTC 2018
New revision: 477157
URL: https://svnweb.freebsd.org/changeset/ports/477157

Log:
  MFH: r476852 r476934

  mysql57-{client, server}: Update ports to 5.7.23
  This update includes Oracle Critical Patch Advisory published on July 2018
  More info:
  http://www.oracle.com/technetwork/security-advisory/cpujul2018-4258247.html#AppendixMSQL

  PR:		229860
  Submitted by:	Dani <i.dani@outlook.com<
  Reported by:	Markus Kohlmeyer <rootservice@gmail.com>
  Reviewed by:	brnrd , koobs
  Sponsored by:	The FreeBSD Foundation

  mysql57-server: Fix build with LibreSSL 2.7

  PR:		230527
  Submitted by:	Markus Kohlmeyer <rootservice@gmail.com>
  Reported by:	Markus Kohlmeyer <rootservice@gmail.com>
  Sponsored by:	The FreeBSD Foundation

  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2018Q3/
  branches/2018Q3/databases/mysql57-client/Makefile
  branches/2018Q3/databases/mysql57-server/Makefile
  branches/2018Q3/databases/mysql57-server/distinfo
  branches/2018Q3/databases/mysql57-server/files/patch-sql_mysqld.cc