Created attachment 196152 [details] Make "check_diff new_only" not generate spurious emails Many periodic scripts check log files and generate an email if there is something new. Often, you receive spurious emails like this: > myhost kernel log messages: > > -- End of security output -- Obviously, there are no log messages to report. Reason is a logic error in "check_diff new_only" which should generates a message only if there are new lines in given log. Unfortunately, a message is also generated if there are __removed__ lines, even though those removed lines are not shown (and not meant to be shown). I've attached a fix.
I still get spurious get emails from periodic security scripts. Could you/someone please apply the patch?
Comment on attachment 196152 [details] Make "check_diff new_only" not generate spurious emails ^Triage: adjust to modern standards.
^Triage: clear the now obsolete 'patch' keyword. To submitter: is this aging PR still relevant?
Meanwhile there was a patch applied solving exactly this issue: Commit 05ef7ed Use '^[>+][^+]' instead of '^[>+]' with grep(1) when filtering the diff(1) output between two files in "new_only"-mode So, this PR can be closed.