Bug 230618 - lang/cling: Installs some non-header files as headers
Summary: lang/cling: Installs some non-header files as headers
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mahdi Mokhtari
URL:
Keywords:
Depends on: 230637
Blocks:
  Show dependency tree / graph
 
Reported: 2018-08-14 08:17 UTC by Yuri Victorovich
Modified: 2018-08-15 13:20 UTC (History)
1 user (show)

See Also:
mmokhi: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2018-08-14 08:17:37 UTC 
The version 0.4 installs invalid headers. For example, every file in the folder /usr/local/include/cling/Interpreter/ looks like this:

> #!/bin/sh
> # $FreeBSD: head/lang/cling/files/llvm-wrapper.sh.in 454856 2017-11-24 23:17:50Z dbaio $
> 
> LLVM_PREFIX="/usr/local/llvm39_cern-root"
> LLVM_SUFFIX="39_cern-root"
> 
> tool=$(basename $0)
> tool="${LLVM_PREFIX}/bin/${tool%${LLVM_SUFFIX}}"
> LD_LIBRARY_PATH="${LD_LIBRARY_PATH:+${LD_LIBRARY_PATH}:}${LLVM_PREFIX}/lib" \
>     "${tool}" "${@}"

And the files have a high link count, they look like hard links of each other.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2018-08-14 08:29:16 UTC 
It looks like these lines are the culprit:

> .for file in ${CLING_FILES:C/^/XXXX/1:NXXXX*}
>         ${LN} -f ${STAGEDIR}${PREFIX}/${FIRST_FILE} ${STAGEDIR}${PREFIX}/${file}
> .endfor

They hard-link all headers to bin/cling (!).
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2018-08-15 01:34:36 UTC 
New version is available: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230637
Comment 3 Mahdi Mokhtari freebsd_committer freebsd_triage 2018-08-15 13:20:09 UTC 
Fixed on r477226