Bug 230635 - [regression] Spam in console after r336593 (NFS mounted)
Summary: [regression] Spam in console after r336593 (NFS mounted)
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2018-08-14 22:29 UTC by Andrey Fesenko
Modified: 2018-08-21 15:33 UTC (History)
2 users (show)

See Also:


Attachments
Fix? (738 bytes, patch)
2018-08-17 12:34 UTC, Colin Percival
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Fesenko 2018-08-14 22:29:26 UTC
After https://svnweb.freebsd.org/base?view=revision&revision=336593
any make action starting spam errors (svn not work on NFS mounted
partitions)

svn: E155016: The working copy database at '/usr/src' is corrupt.
svn: E155016: The working copy database at '/usr/src' is corrupt.
make[2]: "/usr/src/release/Makefile.ec2" line 24: warning:
"/usr/local/bin/svn info --show-item last-changed-revision /usr/sr
c/release/.." returned non-zero status
svn: E155016: The working copy database at '/usr/src' is corrupt.
svn: E155016: The working copy database at '/usr/src' is corrupt.
make[2]: "/usr/src/release/Makefile.ec2" line 24: warning:
"/usr/local/bin/svn info --show-item last-changed-revision /usr/sr
c/release/.." returned non-zero status
Comment 1 Colin Percival freebsd_committer freebsd_triage 2018-08-15 06:39:54 UTC
Do you have the later commits which check if /usr/src/.svn exists before running svn?
Comment 2 Andrey Fesenko 2018-08-15 09:01:03 UTC
Yes last my test install Rev: 337791, error exist.

My build server have and export full /usr/src (/usr/obj)
On notebook I'm mount /usr/src (exists .svn and /usr/obj) and install

Before the resulted commit, the given script worked without errors
Comment 3 Colin Percival freebsd_committer freebsd_triage 2018-08-15 12:49:03 UTC
Hmm, if we see that we have an SVN checkout, I don't know that there's any good way to determine that we shouldn't be using svn to look at it.

Is this a situation where we should simply add "2>/dev/null || true" to hide the errors?
Comment 4 Glen Barber freebsd_committer freebsd_triage 2018-08-15 14:41:20 UTC
I'm trying to understand exactly what is happening here, because the commit in question should in no way impact the /usr/src checkout.

Is the /usr/src export on the NFS host in fact corrupt?

Two ways off-hand I can think about that can cause this is:

1) A network interruption during 'svn checkout' or 'svn update' of the tree;
2) concurrent svn commands attempting to manipulate or read from the svn database, for example a 'svn update' from one NFS client while 'svn status' from another NFS client.

Can you show what 'svn status' on the NFS exported share from the host looks like?  It might be a bit verbose, so the top 20 or so lines might be sufficient.
Comment 5 Andrey Fesenko 2018-08-15 22:20:17 UTC
(In reply to Colin Percival from comment #3)

Maybe this will be enough

(In reply to Glen Barber from comment #4)

On build server simple zfs set sharenfs for /usr/src and /usr/obj

On notebook mount_nfs

If run any svn/svnlite command on build server all work fine

build:/usr/src # svnlite info
Path: .
Working Copy Root Path: /usr/src
..,

On notebook

x220:/usr/src # svnlite info
svn: E155016: The working copy database at '/usr/src' is corrupt.

But since no commands are made on the laptop with svn, no problems arose up to this commit.

Now, too, there is no particular problem, only that unnecessary error messages are not present
Comment 6 Colin Percival freebsd_committer freebsd_triage 2018-08-17 12:34:41 UTC
Created attachment 196280 [details]
Fix?

Does this fix the problem?
Comment 7 Andrey Fesenko 2018-08-18 12:59:18 UTC
(In reply to Colin Percival from comment #6)

Yes, it's patch work fine.
Comment 8 Colin Percival freebsd_committer freebsd_triage 2018-08-21 15:33:27 UTC
Fixed in HEAD (r338141).  I'll MFC this at the same time as all the related changes.