Bug 230733 - lang/go14: Always build with GO386=387 to allow bootstrapping lang/go on older i386 lacking SSE2
Summary: lang/go14: Always build with GO386=387 to allow bootstrapping lang/go on olde...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Julien Laffaye
URL:
Keywords:
Depends on:
Blocks: 230731
  Show dependency treegraph
 
Reported: 2018-08-18 16:46 UTC by Dmitri Goutnik
Modified: 2018-08-19 13:26 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (jlaffaye)


Attachments
patch file (531 bytes, patch)
2018-08-18 16:46 UTC, Dmitri Goutnik
dmgk: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer 2018-08-18 16:46:03 UTC
Created attachment 196321 [details]
patch file

poudriere testport: OK on 112a, 104i
Comment 1 commit-hook freebsd_committer 2018-08-19 13:25:19 UTC
A commit references this bug:

Author: jlaffaye
Date: Sun Aug 19 13:25:06 UTC 2018
New revision: 477571
URL: https://svnweb.freebsd.org/changeset/ports/477571

Log:
  Build lang/go14 without SSE2

  This allows to build lang/go14 on old x86 CPUs without SSE2 instructions.
  This has an impact on generated machine code performance, but lang/go14
  is only useful to boostrap lang/go so it is ok to do so unconditionally.

  PR:		230733
  Submitted by:	Dmitri Goutnik <dg@syrec.org>

Changes:
  head/lang/go14/Makefile
Comment 2 Julien Laffaye freebsd_committer 2018-08-19 13:26:04 UTC
Committed, thanks!